Hello All,
My instructor gave me a question to solve , its really simple but it keeps displaying me 0
the questions says :
Write a C program to Calculate and display the product of the even integers from 2 to 50.
here is my work and i dunno why it displays 0.
Code:#include <stdio.h> #include <conio.h> main() { int i=2,P; while(i<50) { i=i+2; P=P*i; } printf("the product is %d",P); getch(); }
You didn't initialize P - right now, P just happens to be whatever is in memory when you declared it, and that value happened to be 0 here.
The product of even integers from 2 to 50 is 2^25 * 25! I believe which FAR exceeds the capacity of an integer. 2^20 itself is over 1 million! You may want to consider approximating that value or using some larger primitive type.
1. Get rid of gets(). Never ever ever use it again. Replace it with fgets() and use that instead.
2. Get rid of void main and replace it with int main(void) and return 0 at the end of the function.
3. Get rid of conio.h and other antiquated DOS crap headers.
4. Don't cast the return value of malloc, even if you always always always make sure that stdlib.h is included.
mm kk i corrected it and made it double instead of int but idk why the instructor put it in int if it wont be able to work that way ? weired , anyways thanks for the help, appreciate it
From Claudiu's calculation: 2 ^ 25 * 25 = 838 860 800
The upper range of a signed integer on most 32 bit machines: 2 ^ 31 - 1 = 2 147 483 647
It should fit.
25! not just 25.
Think about it. There are 25 even numbers. If you extract the 2 factor from each one you end up with 2^25. The rest is the product of 1*2*3...*25.
1. Get rid of gets(). Never ever ever use it again. Replace it with fgets() and use that instead.
2. Get rid of void main and replace it with int main(void) and return 0 at the end of the function.
3. Get rid of conio.h and other antiquated DOS crap headers.
4. Don't cast the return value of malloc, even if you always always always make sure that stdlib.h is included.
Oh lol, my bad. I thought that was just enthusiasm or awe.
