Segmentation Fault

Hello, I'm making a program that copy value from the source to the destination.

Here is the code :

in .c

Code:

---

void test_insertFP (void)
{

    struct fp_des * p_fp;

    UC8 * p;
    UC8 dd, pp;
    p_fp= (struct fp_des *) malloc (sizeof (struct fp_des));
    p = (UC8*) malloc (sizeof (1));

    p_fp->p = &(dd);
    dd = 20;
    p = &(pp);
    insertFP (p_fp, p);
    (pp == dd);


}

---

I define UC8 as "unsigned char"
Build succesful, but I have segmentation fault.
Thanks for the help

Quote:

---

Originally Posted by dulipat

I have segmentation fault.
Thanks for the help

---

Have you made any attempt to isolate where? Why did you choose that function to post? What's this:

Code:

---

  insertFP (p_fp, p);

---

A couple of things I'll point out:

Code:

---

    UC8 dd, pp;
    p_fp= (struct fp_des *) malloc (sizeof (struct fp_des));
    p = (UC8*) malloc (sizeof (1));

    p_fp->p = &(dd);
    dd = 20;
  p = &(pp);
    insertFP (p_fp, p);
    (pp == dd);  // totally irrelevant and meaningless

---

The red part is a memory leak. You allocate a byte to p, then you throw the handle away by re-assigning it to something else.

problem solved..thx

Why do you go ahead and malloc one byte, for something that looks like it's a member of fp_des struct? I'm thinking about the p_fp->p line, if p is a member of p_fp, you already got the memory from the first malloc call.

Also, p is a pointer, so the size is not 1 but at least 4, possibly 8.