Thread: Small Function problem. Would appreciate any help given. <3

Hey there. I have a file function that is not working correctly and am a bit stumped by it. I'd appreciate any help.

Function prototype:

Code:

void SaveFile(student list[], FILE *database);

Function definition:

Code:

void SaveFile(student list[], FILE *database)
{
database = fopen("database.txt","w"); //Here I am trying to connect to the file and have it create a file
SaveFile(list, database); //then the program prints the list to the file
fclose(database);//and then closes the file
}

Function call:

Code:

SaveFile(list, &database);

Every time I set up the function call the program will not execute properly. It terminates and errors half way through the execution. Help? Thank you.

And I do have the File defined.

Code:

FILE* database;

So you are calling the function from itself, infinitely many times. Of course that's not going to work. Did you intend to call a different function on that second line?

(Also, if you have "FILE* database", then "&database" is not of type FILE*, but rather FILE**.)

The function call is where I am stuck.

I am a beginner in intro to c, I know what I want to do, just trying to get it to do what I want it to do is what is not working out for me. ):

How would I function call the file definition if &database is wrong in SaveFile(list, &database);

Remove the & from the call's parameter.

Ack! I've been Ninja-posted by a bear lover!!

Still isn't executing though. ):

So you still have a huge problem with the recursion. You need to call a different function inside SaveFile, not the same one.

Is the function still calling itself, infinitely?

I guess it is by accident. The 2nd line is suppose to print the list to the file, how would I fix that?

Use one of the file printing functions, like fprintf, or fwrite, to write the list to the file.

Is it possible to write a function to the file?

Of course not. (You can write what the function returns....)

See.. I'm stumped because throughout my code I am altering the list. [adding to it, deleting to it, clearing it, ect.]

And I need to be able to save the current list, at whatever time it maybe, to the file.

Which would be my display function.

However, would writing what my display function returns into my file work?

What your display function returns is almost certainly what your list is, so yes.

EDIT: Typing too fast. What your display function displays is almost certainly what your list is.

The function is void. ]: I'm so confused right now. I can get the file to open and close and create itself but simply don't know how to get display to write into it.

Code:

 void Display(student list[], int num)
 {
	 int i;
	 for(i=0;i<num;i++)
	 {
		 printf("\nName:%s", list[i].name);
		 printf("\nGPA:%lf", list[i].gpa);
		 printf("\nID: %d\n", list[i].id);
	 }
 }

Especially since it is void.