MPI send message

I am trying to send an array of character but when i receive it in the other processor i receive it with garbage !!! any suggestion?

Code:

#include "stdafx.h"
#include <stdio.h>
#include "mpi.h"

int main (int argc, char *argv[])
{  
	MPI_Status s;
   int size, rank;
   char line [128]; 
   //char* str="hjfjh";
   static const char filename[] = "file.txt";
   MPI_Init (&argc, &argv);
   MPI_Comm_size (MPI_COMM_WORLD, &size);
   MPI_Comm_rank (MPI_COMM_WORLD, &rank);
   
   if (rank == 0) // Master process
   { 
 
   FILE *file = fopen ( filename, "r" );
   if ( file != NULL )
   {
     /* or other suitable maximum line size */
 
      while ( fgets ( line, sizeof line, file ) != NULL ) /* read a line */
      {
         //fputs ( line, stdout ); /* write the line */
 
		  MPI_Send ((void *)&line, 1, MPI_CHAR, 1, 0xACE5, MPI_COMM_WORLD);     

	  }
      fclose ( file );
   }
   else
   {
      perror ( filename ); /* why didn't the file open? */
   }
  
   }

   else
   { 
	    printf ("Receiving data . . .\n");
		printf("\n\n line %s\n",line);
   
      {
		  MPI_Recv (&line, 1, MPI_CHAR, 0, 0xACE5, MPI_COMM_WORLD, &s);
          printf ("[%d] sent %s\n", 0, line);
      }
   }
 
   MPI_Finalize();
   return 0;
}

If my reading of the manual is correct, the 1 just means you're sending the first character, not the entire line?

yes i want to send any thing from the file without garbage !!!

Well, let's see some data. Or better yet, I'll provide some you can test with. How's that work? What do you get if you use the following as your .txt file:

Code:

The times that try men's souls
have come and gone and come back again
in a whirligig of emotion, a maelstrom of temper
stringing us out to dry
  And yet, and yet
it is not the end of the road
so much is still yet to be done
  And yet, and yet
no decisions are set in stone for eternity
or forever out of bounds
  And yet, and yet
eternity is coming soon
replacing all of our comfort
replacing it all with fear
out of touch with bedrock
replacing it with quicksand

If you can, try that and tell me what answer you get.

thanks for your replay but i fix my error through your notation
my solution is: i should set the length in send && receive to be 128 instead of 1
to be like MPI_Send ((void *)&line, 128, MPI_CHAR, 1, 0xACE5, MPI_COMM_WORLD);

in order to read the whole line !!
thanks again

Hi M. Samy
my problem is how to send for each Task 3 or 4 works like :
1- helloTimwhereareyou
2- helloTimwhereyoulivethesedays
3- SilaDodohelloTimwhereyoulivethesedays
4- HihelloTimwhereyoulivethesedays
as you without space at a same time
then in each task add for each
add to each word any char at end like '#'
then in master recieve them back with new modification