Pointer without a cast error

[mhunt007]

I've been playing around with this sorting program and got an error message while compiling it:

"[Warning] passing arg 2 makes integer from pointer without a cast"

The program in question follows:

/* upBal.c - update balances */

   #include <stdio.h>
   #include <stdlib.h>
   #define MAX_CUSTOMERS 100
   struct custRec
   {
   	int ID;
   	float Bal;
   };
  /* prototypes of functions */
  int readInput(struct custRec *, char *);
  void sortData(struct custRec *, int);
  void printRecords(struct custRec*, int);
  void upDateBalances(struct custRec*, int);
  int main()
  {
  	int noOfRecords;
  	struct custRec custs[MAX_CUSTOMERS];
  	struct custRec upBal[MAX_CUSTOMERS];
  	/* read the input */
  	noOfRecords = readInput(custs, "cust.dat");
  	noOfRecords = readInput(upBal,"update.dat");
  	/* sort the both arrays */
  	sortData(custs,noOfRecords);
  	sortData(upBal,noOfRecords);
  	/* update the balances */
 	upDateBalances(custs,upBal);
  	/* print the updated values */
  	printf("Ater updating\n");
  	printRecords(custs,noOfRecords);
  	return 0;
  }
  
  /* read the input file and put data into the
  	array that records points at  */
  int readInput(struct custRec *records, char *fileName)
  {
  	FILE *input = fopen(fileName,"r");
  	int noOfRecords = 0;
  	char tempLane[240];
  	int tempCustId;
  	float tempCustBal;
  	if ( input == 0)	/* can't open filename */
  	{
  		fprintf(stderr,"Can not open %s\n", fileName);
  		fprintf(stderr,"please check\n\n");
  		exit(-1);
  	}
  	while (fgets(tempLane,240,input))
  	{
  		/* if the first character is a "#" ignore */
  		if (tempLane[0] == '#')
  		{
  			continue;
  		}
  		/* make sure that the line has 2 numbers */
  		if (sscanf(tempLane,"%d, %f",
  				&tempCustId, &tempCustBal) == 2)
  		{
  			records[noOfRecords].ID = tempCustId;
  			records[noOfRecords].Bal = tempCustBal;
  			noOfRecords++;
  		}
  	}
  	fclose(input);
  	return noOfRecords;
  }

/* sort the records */
  void sortData(struct custRec *custs, int noOfRecs)
  {
  	int inner, outer, didSwap;
  	struct custRec temp;
  	/* sort the array */
  	for (outer = 1; outer < noOfRecs; outer++)
  	{
  		didSwap = 0;
  		for (inner = noOfRecs-1; inner >= outer ; inner--)
  		{
  			if (custs[inner-1].ID > custs[inner].ID )
  			{
  				temp = custs[inner-1];
  				custs[inner-1] = custs[inner];
  				custs[inner] = temp;
  				didSwap = 1;
  			}
  		} /* inner loop */
  		if (didSwap == 0)
  		{
  			break;
  		}
  	} /* outer loop */
  	return ;
  }
  void printRecords(struct custRec* custs, int noOfRecs)
  {
  	int i;
  	/* print values */
  	printf("Cust ID    Balance\n");
  	for (i = 0; i < noOfRecs ; i++)
  	{
 		printf("%5d %12.2f\n",
 			custs[i].ID, custs[i].Bal);
 	}
 	return;
 }

 void upDateBalances(struct custRec* custs, struct custRec* newBalances, int noOfRecords)
 {
 	int i;
 	for (i = 0 ; i < noOfRecords; i++)
	{
 		custs[i].Bal += newBalances[i].Bal;
 	}
 	return;
 }

I believe that the problem lies in the 'upDateBalances' function because the program will compile when I comment it out as well as its mention within the main program.

The compiling error highlights the piece in the main program

upDateBalances(custs,upBal);

I'm sure that it's something trivial but yet I cannot seem to see what's wrong. If anyone has any ideas, I'd much appreciate any input. Thanks.

[claudiu]

Well that function takes three arguments and you are passing two.

[vart]

Well that function takes three arguments and you are passing two.

also the function prototype is different from function definition...

[claudiu]

Yes, vart is correct. I hadn't even looked at that.

@OP you need to declare, define and call the function in a "unified" fashion.

[mhunt007]

Well that function takes three arguments and you are passing two.

Ah, so the function call would NOT read

upDateBalances(custs,upBal);

but instead

upDateBalances(custs,newBalances, noOfRecords);

which would be three arguments rather than two.

[mhunt007]

Yes, vart is correct. I hadn't even looked at that.

@OP you need to declare, define and call the function in a "unified" fashion.

Thanks claudiu. What do you mean by 'unified' fashion?

[laserlight]

What do you mean by 'unified' fashion?

I think that claudiu just means that the declaration of a function and its definition must be compatible. You cannot declare the function as having exactly two parameters, then define it as having exactly three parameters.

[claudiu]

I think that claudiu just means that the declaration of a function and its definition must be compatible. You cannot declare the function as having exactly two parameters, then define it as having exactly three parameters.

Yes, thanks for clearing that out laserlight.

[mhunt007]

I think that claudiu just means that the declaration of a function and its definition must be compatible. You cannot declare the function as having exactly two parameters, then define it as having exactly three parameters.

So I am defining the function to have three parameters

void upDateBalances(struct custRec* custs, struct custRec* newBalances, int noOfRecords)

but declaring the function to have only two

upDateBalances(custs,upBal);

Is that what you're referring to? I tried to remove the 'noOfRecords' reference from the defined function but that did not work for me.

[laserlight]

Is that what you're referring to?

Not quite. This is a forward declaration of upDateBalances:

void upDateBalances(struct custRec*, int);

This is a call of upDateBalances:

upDateBalances(custs,upBal);

This is the definition of upDateBalances:

void upDateBalances(struct custRec* custs, struct custRec* newBalances, int noOfRecords)
{
    int i;
    for (i = 0 ; i < noOfRecords; i++)
    {
        custs[i].Bal += newBalances[i].Bal;
    }
    return;
}

I tried to remove the 'noOfRecords' reference from the defined function but that did not work for me.

Well, you cannot just remove the noOfRecords parameter because you are actually using it. Rather, it looks like you should change the declaration and function call to match the definition.

[mhunt007]

Not quite. This is a forward declaration of upDateBalances:

void upDateBalances(struct custRec*, int);

This is a call of upDateBalances:

upDateBalances(custs,upBal);

This is the definition of upDateBalances:

void upDateBalances(struct custRec* custs, struct custRec* newBalances, int noOfRecords)
{
    int i;
    for (i = 0 ; i < noOfRecords; i++)
    {
        custs[i].Bal += newBalances[i].Bal;
    }
    return;
}

Well, you cannot just remove the noOfRecords parameter because you are actually using it. Rather, it looks like you should change the declaration and function call to match the definition.

I tried to match the forward declaration

void upDateBalances(struct custRec *,struct custRec *, int);

with the call

upDateBalances(custs,upBal,noOfRecords);

to match the definition

void upDateBalances(struct custRec* custs, struct custRec* newBalances, int noOfRecords)

So now the program compiles successfully but does not work if that makes any sense.

[laserlight]

How does it not work?

[mhunt007]

There is no console which usually pops up which tells you what the program is doing and also says, "Press and key to exit..."
Also, the output.dat file is empty.

[laserlight]

Run your program from a command prompt.

[mhunt007]

Okay. The program runs and the command window just states

After sorting
Cust ID Bal

Press any key to exit...

I didn't see anything in the output.dat file. I removed the comma between the '%d, %f' in the sscanf which enabled me to read the screen output on another program but it doesn't seem to be working for this one.