conflicting types for getline() fix

[saqib_]

I am trying to compile a small program on linux. Here is the code.

#include <stdio.h>

#define MAXLINE 1000

int getline(char line[], int maxline);
void copy(char to[], char from[]);

int main(){
	int len;
	int max;
	char line[MAXLINE];
	char longest[MAXLINE];

	max = 0;
	while((len = getline(line, MAXLINE)) > 0){
		if(len > max) {
			max = len;
			copy(longest, line);
		}
		if(max > 0){
			printf("%s", longest);
		}
	}
return 0;
}

int getline(char s[], int lim[]){
	int c, i;

	for(i = 0; i < lim-1 && (c = getchar()) != EOF && c != '\n'; ++i){
		s[i] = c;
		++i;
	}
	s[i] = '\0';
	return i;
}

void copy(char to[], char from[]){
	int i;

	i = 0;
	while((to[i] = from[i]) != '\0')
	++i;
}

and here are the errors that gcc gave me.

line.c:5: error: conflicting types for ‘getline’
/usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here
line.c:27: error: conflicting types for ‘getline’
/usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here
line.c: In function ‘getline’:
line.c:30: warning: comparison between pointer and integer

I couldn't get error: conflicting types for getline fix.

[quzah]

I'm not sure how it could get any clearer. It gives you line numbers, and tells you what's wrong:

int getline(char line[], int maxline);

int getline(char s[], int lim[]){

Quzah.

[saqib_]

: ) Lols. How could I miss that. I saw that many times. I think I was not in a frame of mind then. Well, correcting that it still annoys me though.

#include <stdio.h>

#define MAXLINE 1000

int getline(char line[], int maxline);
void copy(char to[], char from[]);

int main(){
	int len;
	int max;
	char line[MAXLINE];
	char longest[MAXLINE];

	max = 0;
	while((len = getline(line, MAXLINE)) > 0){
		if(len > max) {
			max = len;
			copy(longest, line);
		}
		if(max > 0){
			printf("%s", longest);
		}
	}
return 0;
}

int getline(char s[], int lim){
	int c, i;

	for(i = 0; i < lim-1 && (c = getchar()) != EOF && c != '\n'; ++i){
		s[i] = c;
		++i;
	}
	s[i] = '\0';
	return i;
}

void copy(char to[], char from[]){
	int i;

	i = 0;
	while((to[i] = from[i]) != '\0')
	++i;
}

line.c:5: error: conflicting types for ‘getline’
/usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here
line.c:27: error: conflicting types for ‘getline’
/usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here

What is wrong now?

[vart]

your stdio.h already has a declaration of getline and it is different from your own declaration - try to rename your function to avoid conflicts

[saqib_]

Thanks.