Apache Module - string question

**markwillis82** · 03-24-2010

Hi guys,
i've been trying too modify an apache module to write some stuff to a text file - and i'm struggling to get the last character off the url (trying to match against "/" or print to a file)

i've tried the methods from here - How do I get the last character of a string?

But I think i'm missing something... this is the code i've got

Code:

	    char mystr[50];
	    mystr = "this is a string//"; //r->uri;
	    end_char = mystr[(strlen(mystr)-1)];

		if(strrchr(mystr,"/") == (strlen(mystr) - 1)) {
		    fprintf(files, "end char: %s\n",  "slash");
		} else {
		    fprintf(files, "end char: %s\n",  "no slash");
		}
		    fprintf(files, "efef: %s\n", end_char );
		    
		    fprintf(files, "str length: %u - %u\n",  strlen(mystr),strrchr(mystr,"/"));

many different methods - trying to get the last character.

Can anyone shed any light on what i'm doing wrong.

EDIT: The writing to files works - and this is just a snippet

Thanks

Mark Willis

**rags_to_riches** · 03-24-2010

You're trying to write an Apache module and you don't know basic string handling??? That's ambitious.

Code:

"/"

is not a single character; it's an array of two characters, '/' and '\0'.

strrchr returns a pointer to the last character...why are you comparing the return value to the length of the string - 1?

**markwillis82** · 03-24-2010

I'm not writing an apache module - just making a few tweaks too an already working one, i'm a web developer by day (LAMP) and all off my other modifications work lovely - just this one causing me a headache.

All I need to do is check whether the last character in the string is a trailing slash (so: "domain.com/something/this" returns false, but "domain.com/something/this/" returns true

**Adak** · 03-24-2010

Your end_char gives you the last char of the string, I don't understand why you don't use it?

Code:

if( end_char == '/') {
  do this
  and that
}
else {
  do something else
  and then this too
}

**markwillis82** · 03-24-2010

I see where I went wrong - I guess " and ' act differently in C. as that works lovely - Thanks Adak.

**markwillis82** · 03-24-2010

I've got some more questions if your able to help me?

At the moment i've modified the mod_evasive apache module to log attacks rather then ban them - this lets me do some post processing on the log files - currently it uses hash tables (ntt?) to store timestamps and hit counts, I would like to modify this to store a list of hit urls also - but this is beyond my current level of C.

Would someone be able to take a quick look?

Thanks...

(see attached file)

Thread: Apache Module - string question

Thread Tools

Search Thread

Display

Apache Module - string question

Similar Threads

Reusing a string pointer question

Program using classes - keeps crashing

can anyone see anything wrong with this code

String array question