storing players names

[billet]

Hey i could use some help, im working on a snakes and ladders game project non visual. I am new to C programming I need to write the part of the program which asks the user(s) to enter amount of players in the game, then store that number so the program can ask those amount of players names. Then the players names to be stored to count the score during the game and giving the final score.

so far i have this:

int i,j;
	char name[20];

	printf("enter number of players between 1-4:");
	scanf("%d",&i);
	printf("you entered %d", i);
	
	{printf("please enter your names"),i;}
	scanf("%s",&name);
	printf("Player names: %s", name);

Would appreciate some help! thanks.

[Salem]

> char name[20];
Try
char names[4][20];

Then later
scanf( "%s", names[i] );

[kira_coder]

you shouldn't use const char limit since it could lead to stack over flow if its more than 4 you should allocate it even though its would be less efficient but will help you getting away from problems and you shouldn't use scanf either in reading a string coz it would stop after reaching first space it will not read after that you can either read it by getchar or fgets

[billet]

> char name[20];
Try
char names[4][20];

Then later
scanf( "%s", names[i] );

Thanks but that doesnt work, I want the use to be able to enter the amount of players between 1-4. Then the program to recognise that and ask the players to enter their names which can be stored. Sorry i am bit useless at programming

[kira_coder]

Thanks but that doesnt work, I want the use to be able to enter the amount of players between 1-4. Then the program to recognise that and ask the players to enter their names which can be stored. Sorry i am bit useless at programming

you would have to use that in a loop reading each array
for example
for(int i = 0 ; i < sizeof(szName) / sizeof(szName[0];i++)
so you could read each index. but you shouldn't use what salem said since it would lead to potential bug's in the code.you should have szName as ptr to ptr and allocate according to num of ppl you got then read using your own getchar or fgets.

[Adak]

You'll need to expand your array to make more space. Right now, you only have room for 20 characters.

Try

int names[8][25];

That will give you space for 8 names, each name having up to 24 char's.

Then you can loop through your names input. It's fine if you have only fewer than 8 names. Your player_num variable, will control all the output and game play. Don't use i for the player_num, though.

Traditionally, i is a loop counter, and you want something much more descriptive for your other variable names. It just helps a lot.

#include <stdio.h>

int main() {
  int i, player_num; 
  char names[8][25];

  printf("\n\n");  

  //user inputs value of player_num, here, as you have now
  

  for(i = 0; i < player_num; i++) {
    printf("Enter the player's name: ");
    scanf("%s", names[i]);  //enters name and creates a newline <enter key>
    getchar();                   //removes the newline from the keyboard buffer
  }
  printf("\n\n");
  for(i = 0; i < player_num; i++)
    printf("\n%s", names[i]);
  
  printf("\n\n\t\t\t     press enter when ready");

  getchar();   //holds the console window open until you press enter
  return 0;
}

For very small amounts of memory, as a beginner, it's much easier to just have a fixed number of names made available, than to start working with dynamically allocating memory. That can best be done, a bit later in your education.

[_Mike]

but you shouldn't use what salem said since it would lead to potential bug's in the code.you should have szName as ptr to ptr and allocate according to num of ppl you got ...

If the max limit is well defined (OP said 1 to 4 players) then there's really no problem using a fixed size array.

... then read using your own getchar or fgets.

Huh? What's wrong with using the ones from the standard library?

[kira_coder]

If the max limit is well defined (OP said 1 to 4 players) then there's really no problem using a fixed size array.


Huh? What's wrong with using the ones from the standard library?

scanf stops at first space so you cant read name such as you cant read name like 91 92 which ppl have to read there full name obviously also fgets and getchar() are stand library its not about max limit defined since user whos using application won't really care abt max lim unless you make a test not to go beyond that limit.

[_Mike]

obviously also fgets and getchar() are stand library

I know, which is why I wondered why he should use "[his] own" and not those?

its not about max limit defined since user whos using application won't really care abt max lim unless you make a test not to go beyond that limit.

Well if you as a programmer says there's an upper limit it would be kinda dumb not to validate the input against it. Otherwise, why even have a limit in first place?

[kira_coder]

well as for fgets because it does same thing as scanf but could read all line and add \n before NULL and for the limit I said it coz there was not for me coz ofcourse I already know that but because the guy asking the question coz as his is a beginner maybe it wouldn't come to his mind to test.

[billet]

When i try to run the programme i get an error saying "the variable player_num is being used without being initialized" what does that mean??

You'll need to expand your array to make more space. Right now, you only have room for 20 characters.

Try

int names[8][25];

That will give you space for 8 names, each name having up to 24 char's.

Then you can loop through your names input. It's fine if you have only fewer than 8 names. Your player_num variable, will control all the output and game play. Don't use i for the player_num, though.

Traditionally, i is a loop counter, and you want something much more descriptive for your other variable names. It just helps a lot.

#include <stdio.h>

int main() {
  int i, player_num; 
  char names[8][25];

  printf("\n\n");  

  //user inputs value of player_num, here, as you have now
  

  for(i = 0; i < player_num; i++) {
    printf("Enter the player's name: ");
    scanf("%s", names[i]);  //enters name and creates a newline <enter key>
    getchar();                   //removes the newline from the keyboard buffer
  }
  printf("\n\n");
  for(i = 0; i < player_num; i++)
    printf("\n%s", names[i]);
  
  printf("\n\n\t\t\t     press enter when ready");

  getchar();   //holds the console window open until you press enter
  return 0;
}

For very small amounts of memory, as a beginner, it's much easier to just have a fixed number of names made available, than to start working with dynamically allocating memory. That can best be done, a bit later in your education.

[billet]

My bad ! it works now! much appreciated this forum is great! i owe you all a pat on the back cheers!

When i try to run the programme i get an error saying "the variable player_num is being used without being initialized" what does that mean??

[billet]

The program works fine just need to know how i can store the players names that are entered in to the memory so they can be used record the scores? thanks

int i, player_num; 
  char names[8][25];

  printf("\n\n");  

start:
  printf("enter number of players between 1-4:"); //user inputs value of player_num
	scanf("%d",&player_num);
	if (player_num > 4)goto start;
		
	else;
	

 for(i = 0; i < player_num; i++) {
    printf("Enter the player's name: ");
    scanf("%s", names[i]);  //enters name and creates a newline <enter key>
    getchar();                   //removes the newline from the keyboard buffer
  }
  printf("\n\n");
  for(i = 0; i < player_num; i++)
    printf("\n%s", names[i]);
  
  printf("\n\n\t\t\t m    press enter when ready");

  getchar();   //holds the console window open until user presses enter

[Adak]

The program works fine just need to know how i can store the players names that are entered in to the memory so they can be used record the scores? thanks

Later on, when you learn about structs, you'd make one struct per player, (which you might call one record per player, with each record having 2 or 3 fields in it).

For now, if you just want to record scores, you could use a simpler array of scores: int scores[8]. Now player 0 (because real programmers start counting with zero, not one), will have score 0, and player[1] will have score[1], etc.

  int i, player_num; 
  char names[8][25];
  int scores[8] = {0};

  printf("\n\n");  


start:
  printf("enter number of players between 1-4:"); //user inputs value of player_num
  scanf("%d",&player_num);
  if (player_num > 4)goto start;
		
	// no else is needed 
	

 for(i = 0; i < player_num; i++) {
    printf("Enter the player's name: ");
    scanf("%s", names[i]);  //enters name and creates a newline <enter key>
    getchar();                   //removes the newline from the keyboard buffer
  }
  printf("\n\n");
  for(i = 0; i < player_num; i++)
    printf("\nName: %s  Score: %d ", names[i], score[i]);
  
  printf("\n\n\t\t\t m    press enter when ready");

  getchar();   //holds the console window open until user presses enter

Something like that. The index (the "i'), in the for loop, is the "glue" that keeps the player associated with the players score. Makes it easy as pie, eh?

[vart]

scanf stops at first space

there are other formats except %s, you know...

like

char buffer[25];
scanf("%24[^\n]",buffer);