Thread: Can someone please help me with my program? I am new to C programming.

Thank you for the response, I was trying to understand how your code works but I am I think it is above my level, I think it is C+ or C++.... I am only falmiliar with C.

I tried copying the code and editing my code into it but I was unable too...

Thanks anyways though

Originally Posted by NeonBlack

I think it's fine for him to use scanf for now. I think he should focus on fixing his program logic before going for this kind of robustness.

I have been working on my code for hours now, do you have any suggestions about how to fix the logic? I tried so many different things I am running out of ideas.

Is this a correct code for reading the first line from the golf.txt document? I know it is not, but I have no clue why I tried to mess around with it...


golf.txt document:

8
3 3 4 5 5 4 3 3 3 4 4 5 4 3 3 5 4 3
3 3 2 4 5 4 4 4 4 5 3 5 3 5 1 4 3 2
4 5 3 4 4 3 5 3 3 3 4 2 3 3 4 4 5 3
3 4 5 6 4 4 4 4 3 5 4 5 4 3 3 5 4 3
2 4 5 5 5 5 5 3 3 5 4 4 2 4 4 5 5 4
4 5 6 3 3 5 4 4 3 3 2 4 5 4 5 5 3 3
2 5 3 5 5 5 3 4 3 4 4 4 3 4 4 5 5 5
3 4 4 5 4 3 4 4 3 4 5 5 4 3 4 4 5 4
4 2 4 3 5 3 3 4 5 2 3 3 5 5 5 3 5 5

Code:

for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore[z]);
    parscore[z] = parscore[z];
    }

Here is your code, working and cleaned up, minus extra logic/variables etc:

Code:

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, ok, j, i, z, n, p, o;
    int tries [8][18];
    int score [8][18];
    int parscore[18];

    ifp = fopen("golf.txt","r");

    fscanf(ifp, "%d\n", &ttl_golfers);
    printf("%d golfers played on this golf course:\n", ttl_golfers);

    for (z=0; z < 18; z++)  {
        fscanf(ifp, "%d ", &parscore[z]);
        parscore[z] = parscore[z];
    }
    fscanf(ifp,"\n");

    for(n=0; n < ttl_golfers; n++) {
        for(i = 0; i < 18; i++) {
            fscanf(ifp, "%d", &tries[n][i]);
            score[n][i] = tries[n][i]- parscore[i];
            printf("Golfer #%d's Score: %d\n", n, score[n][i]);
        }
        fscanf(ifp,"\n");
    }

    fclose(ifp);
    return 0;
}

Please note that this code will ONLY work (and will likely crash) if it is not given a golf.txt file in its current directory that is PERFECTLY formatted, meaning exactly like this:

Code:

8
4 4 3 5 4 3 4 5 6 5 4 4 4 5 5 4 3 3 
4 4 3 6 7 4 4 5 4 5 3 5 3 5 7 5 3 2 
4 5 3 4 6 5 5 6 3 5 4 6 3 3 5 4 5 3 
3 4 5 6 4 4 4 5 5 5 4 5 4 3 3 5 4 3 
2 5 5 6 7 6 5 5 4 6 4 5 6 7 5 5 5 5 
4 5 6 3 3 5 4 4 3 3 2 5 6 6 5 5 3 3 
2 5 3 5 5 5 6 5 4 3 4 5 5 4 4 6 5 5 
6 5 4 5 5 3 5 6 5 4 6 5 6 4 4 6 5 4 
4 4 5 5 3 3 6 5 4 3 3 5 6 5 3 6 5 4

Note that after each of the lines with 18 digist (not the first line with only one digit) there is a single TRAILING space, this is REQUIRED for it be read correctly.

The slightest mistake, such as 2 extra spaces at the end will result in a file that will not be parsed correctly with the code above.

That is why I mentioned the fgets method as its much more flexible with how the file appears, you could put all kinds of stuff to ignroe comments, extra spacing, etc...with fscanf it is a pain

Originally Posted by Adak

Delete the parscore[z] = parscore[z]. That tells you that you are now, you - rubbish.

Nonpuz's idea of a struct is good, but overkill.

I'll look at your code when I return from an errand - about an hour. You just want the "true" score by comparing the par score with the score they made, on each hole, correct?

Right, so the program should output 18 different values that compare the par score to the actual score for each golfer. Thank you Adak.

Originally Posted by nonpuz

Here is your code, working and cleaned up, minus extra logic/variables etc:


Please note that this code will ONLY work (and will likely crash) if it is not given a golf.txt file in its current directory that is PERFECTLY formatted, meaning exactly like this:


Note that after each of the lines with 18 digist (not the first line with only one digit) there is a single TRAILING space, this is REQUIRED for it be read correctly.

The slightest mistake, such as 2 extra spaces at the end will result in a file that will not be parsed correctly with the code above.

That is why I mentioned the fgets method as its much more flexible with how the file appears, you could put all kinds of stuff to ignroe comments, extra spacing, etc...with fscanf it is a pain

THANK YOU~! I will try to look at it for a while to understand what I did wrong.... I would like to get a better understanding on how fgets works because I really don't like scanf. Ill look into when I get a chance... if you have any urls that you would recommend I would definitely read them

Thank you for your help.

The code does not run correctly..I am trying to figure out why.... non-puz

is your golf.txt formatted exactly as I said? each line with 18 digits should have an EXTRA space at the END of the line, ie after the last digit

and there should be no comments or anything in there...works for me

Works great! thank you,
it was my fault, I forgot to refresh my golf.txt document so it was getting the wrong values.


The way it is outputting should be like GOLFER1: -1 2 5 4 3 3 5 4.........(18times for each golfer)

but instead it is outputting like:

Golfer1: -1
Golfer1: 2
Golfer 1:5
...
...
Upto (18times for each golfer)


Any ideas?

Sure - print the golfer number, then in a for loop, print the real scores, and leave off the newline between the scores.

Just one newline between golfer numbers, only.

Code:

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, ok, j, i, z, n, p, o;
    int tries [8][18];
    int score [8][18];
    int parscore[18];

    ifp = fopen("golf.txt","r"); 

    fscanf(ifp, "%d", &ttl_golfers);
    printf("%d golfers played on this golf course:\n", ttl_golfers);

    for (z=0; z < 18; z++)  {
        fscanf(ifp, "%d", &parscore[z]);
        parscore[z] = parscore[z];
    }

    for(n=0; n < ttl_golfers; n++) {
        printf("Golfer #%d Scores:\n", n+1);
        printf("\t1\t2\t3\t4\t5\t6\t7\t8\t9\n\t");
        for(i = 0; i < 9; i++) {
            fscanf(ifp, "%d", &tries[n][i]); 
            score[n][i] = tries[n][i] - parscore[i];
            printf("%d\t", score[n][i]);
        }
        printf("\n\n\t10\t11\t12\t13\t14\t15\t16\t17\t18\n\t");
        for(i = 9; i < 18; i++) {
            fscanf(ifp, "%d", &tries[n][i]); 
            score[n][i] = tries[n][i] - parscore[i];
            printf("%d\t", score[n][i]);
        }
        printf("\n");
    }

    fclose(ifp);
    return 0;
}

Adak is right you dont need the \n stuff in the scanf, just use fscanf(%d and it will look over any whitespace/newlines...

but you have to make sure there is no comments in there and no extra numbers or anything...

the code above displays the results a little nicer and removed the excessive fscanf calls