scanf and integer problems

Hello.
I am currently having problems scanning in an integer to be used for a menu selection.
All goes well with the program until you enter in a non integer value; the program will go into an infinite loop and eventually crash.

I am using scanf to take input from an int

You probably should read this:

STDIN pitfalls

also, you post the code you are using

I don't know which technique you are using for menu selection. I will give you the two way to select the menu.In these ways there is no problem as you mentioned.

Try this,

Code:

main ( int argc, char *argv[] )
{
        int i;
        while(1)
{
        printf ( "Enter the value:"  );
        scanf("%d",&i);
        switch(i)
        {
                case 0:
                        printf( "Valid\n");
                        break;
                default:
                        printf("Default\n");
                        break;
        }
}
}

Another way:

while(1)
        {
        printf ( "Enter the value:"  );
        scanf("%d",&i);
                if(i==1) {
                        printf ( "Value is 1\n"  );
                }
                else if(i==2) {
                        printf ( "Value is 2\n"  );
                }
                else
                        break;
        }

If my understanding is wrong , revert me back.

Try This:

Code:

#include <ctype.h>
#include <stdio.h>
#include <conio.h>

int choice = 0;

int GetInt();

int main()
{
 while(1 == 1)
 {
  printf("1) Start Program\n");
  printf("2) End Program\n");
  choice = GetInt();
  if (choice == 1)
   printf("Starting a new program...\n");
  if (choice == 2)
   exit(1);
 }
}

int GetInt()
{
 /* Init a Char variable with value -1 to 
    not jump out of the loop.*/
 char c = -1;
 /* Loop until the Condition is invalid. */
 while (c > 9 || c < 0)
 {
 c = getch(); /* Get Input*/
 c -= 48; /* Subtract C by 48. E.G '0' = 48 so 
             Subtracting C by 48 gets us an 
             Integer Zero */
 }
 return c; /* Return Whatever is in C */ 
}

Originally Posted by UltraKing227

Try This:

Before you do so, be warned that <conio.h> and getch() and non-standard.

You should check how scanf actually works.

This is the problem when students are given functions which they dont know how they ACTUALLY work.

SCANF function will read the input depending on its argument.

If its %d, it will read an integral number - if the character readed from the file (in this case stdin) isnt a number, it will push the character back on the input.

So the next call to the same scanf will do the same; do nothing - just push the readed char back to input.

All goes well with the program until you enter in a non integer value; the program will go into an infinite loop and eventually crash.

I hope its clear to you WHY the program crashes now.

You could fix this problem by checking if scanf returned 1 (number of args successfully read).

If its 1, proceed. If 0, fprintf(stderr "errormsg"); and exit or do whatever you want.

Imo in error case you could write a function skipline(void) which getchars() the rest of the line.


Also have in mind you need to check EOF when using scanf, as scanf returns specifically EOF when it occurs. Not 0 or 1.


I'd most likely do it with fgets() and atoi. Check out those functions. Or you could write your own getint() which would be even better as fgets has some limitations.