No return on char counting program

metros · 02-09-2010, 10:41 AM

When I execute the following piece of code I'm prompted to typed in some characters, however nothing happens when I press return. Surely a value should be returned indicating how many characters are contained in the input?

Code:

#include <stdio.h>

main()
{
long nc;
nc = 0;
while(getchar() != EOF)
++nc;
printf("%ld\n", nc);
}

jeffcobb · 02-09-2010, 10:56 AM

Ugh, formatting...

Code:

#include <stdio.h>

main()
{
   long nc;
   nc = 0;
   while(getchar() != EOF)
      ++nc;
   printf("%ld\n", nc);
}

Thats a little better and isn't the code clearer now too?
As for your question here is a hint: EOF != '\n' (or maybe '\r' depending on platform)

MK27 · 02-09-2010, 10:59 AM

Because pressing return does not indicate EOF.

Try using:

Code:

while(getchar() != '\n')

instead.

metros · 02-09-2010, 11:02 AM

Thanks all. One more thing..... when the program is running, how do I escape back to normal terminal node?

jeffcobb · 02-09-2010, 11:07 AM

Well, once you escape your while() loop with either CTRL-D (EOF) or ENTER ('\n') it should print the number of characters and exit for you...

02-09-2010, 10:41 AM	#1
metros Registered User Join Date: Feb 2010 Posts: 31	No return on char counting program When I execute the following piece of code I'm prompted to typed in some characters, however nothing happens when I press return. Surely a value should be returned indicating how many characters are contained in the input? Code: #include <stdio.h> main() { long nc; nc = 0; while(getchar() != EOF) ++nc; printf("%ld\n", nc); }
metros is offline

02-09-2010, 10:56 AM	#2
jeffcobb Registered User Join Date: Dec 2009 Location: Henderson, NV Posts: 887	Ugh, formatting... Code: #include <stdio.h> main() { long nc; nc = 0; while(getchar() != EOF) ++nc; printf("%ld\n", nc); } Thats a little better and isn't the code clearer now too? As for your question here is a hint: EOF != '\n' (or maybe '\r' depending on platform) __________________ C/C++ Environment: GNU CC/Emacs Make system: CMake Debuggers: Valgrind/GDB
jeffcobb is offline

02-09-2010, 10:59 AM	#3
MK27 dat is, vast staat Join Date: Jul 2008 Location: SE Queens Posts: 6,612	Because pressing return does not indicate EOF. Try using: Code: while(getchar() != '\n') instead. __________________ C programming resources: GNU C Function and Macro Index -- glibc reference manual The C Book -- nice online learner guide Current ISO draft standard CCAN -- new CPAN like open source library repository GDB tutorial #1 -- gnu debugger tutorials -- GDB tutorial #2 cpwiki -- our wiki on sourceforge
MK27 is offline

02-09-2010, 11:02 AM	#4
metros Registered User Join Date: Feb 2010 Posts: 31	Thanks all. One more thing..... when the program is running, how do I escape back to normal terminal node?
metros is offline

02-09-2010, 11:07 AM	#5
jeffcobb Registered User Join Date: Dec 2009 Location: Henderson, NV Posts: 887	Well, once you escape your while() loop with either CTRL-D (EOF) or ENTER ('\n') it should print the number of characters and exit for you... __________________ C/C++ Environment: GNU CC/Emacs Make system: CMake Debuggers: Valgrind/GDB
jeffcobb is offline

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Compiling Program as .exe with no dependancy on other files	nitesh	C++ Programming	2	11-01-2009 09:54 AM
How can I make this code more elegant?	ejohns85	C++ Programming	3	04-02-2009 08:55 AM
New string functions	Elysia	C Programming	11	03-28-2009 05:03 AM
OpenGL Window	Morgul	Game Programming	1	05-15-2005 12:34 PM
fopen();	GanglyLamb	C Programming	8	11-03-2002 12:39 PM