Syntax problem or Makefile Problem

[mjm22]

Hi,

I have a problem referencing a function in another file. I get the below error and wonder if anyone has any ideas:

MYprog.c: In function `main':
MYprog.c:33: warning: implicit declaration of function `MYFW_SendInform'
MYprog.c:33: error: called object is not a function

I have the following files The intention is that MYFW becomes a libray accessible to a number of developments...
MYFW.h/MYFW.c: A collection of constants and functions that provide common processing tasks
MYprog.h, MYprog.c: The collection of functions to perform the specific tasks in hand.

#MYFW.h
# A header file for the FRAMEWORK.

#ifndef _MYFW_H
#define _MYFW_H

#define MYFWinform \
    (void)MYFW_SendInform(__FILE__, __LINE__, "INFORM")

#endif

MYFW.c
# the source code for the FRAMEWORK.

#include <MYFW.h>

PUBLIC void MYFW_SendInform  (IN char  *pcSourceFile,
                                                   IN int   iSourceLine,
                                                   IN char  *pcMessType)
{
    // I know I'n not using the params, want to get it working first.
     printf("MYFW_SendInform: in\n");
}

#MYprog.h
# A header file for the DEVELOPMENT.

#ifndef MYPROG_H
#define MYPROG_H

#include <MYFW.h>

#endif

#MYprog.c
# The source for the the DEVELOPMENT.

#include "MYprog.h"

int main(int argc, char **argv)
{
    MYFWinform("main: in");
    exit(0);
}

So the MyProg.c includes MYprog.h
MYFW.c includes MYFW.h
and MYProg.h includes MYFW.h.

Is there something wrong with the syntax, the way I've linked the files or is this a problem with the makefile? Should I be compiling the MYFW as an object first? Here is my makefile.....

# makefile
OBJDIR=../OBJ
BINDIR=../../bin
CC=gcc
CFLAGS=-I. -g -Wall
EXE=MYProg
INC=MYFW.h MYProg.h
SRC=MYFW.c MYProg.c

${OBJDIR}/%.o: %.c ${INC}
    ${CC} -c -o $@ $< ${CFLAGS}

MYProg: ${OBJ}
    ${CC} -o ${BINDIR}/${EXE} ${OBJ} ${CFLAGS}

[brewbuck]

There is no visible prototype of MYFW_SendInform. This:

PUBLIC void MYFW_SendInform  (IN char  *pcSourceFile,
                                                   IN int   iSourceLine,
                                                   IN char  *pcMessType);

Needs to be declared in MYFW.h

[mjm22]

There is no visible prototype of MYFW_SendInform. This:

PUBLIC void MYFW_SendInform  (IN char  *pcSourceFile,
                                                   IN int   iSourceLine,
                                                   IN char  *pcMessType);

Needs to be declared in MYFW.h

Thanks.. so obvious.. been looking at the code to long I think. Put it in but I have another error stating:

MYProg.c:33: error: void value not ignored as it ought to be

BTW, just for clarity.. the PUBLIC is a define in the MYFW.h file..

#define PUBLIC 
#define PRIVATE static

This suggests that the MYFW_SendInform function is returning something, but it isn't. All that happens in it is a printf.

Anyone any ideas?

Thanks

Mike