Thread: concatenation

Code:

char mainStr[50], addStr[50], totalStr[100];
gets(mainStr);
scanf("%s", addStr);
    fflush(stdin); //gets() does not work, so  i used scanf.
for (i = 0; totalStr[i] != '\0'; i++)
        {
            totalStr[i] = mainStr[i];
        }
        totalStr[i+1] = ' ';
        for (i = i + 2; totalStr[i] != '\0'; i++)
        {
            totalStr[i] = addStr[i];
        }
        printf("%s", totalStr);

but when it prints, it only prints mainStr

This one is wrong:

Code:

for (i = i + 2; totalStr[i] != '\0'; i++)

Try replacing it with:

Code:

for (i = i + 2; addStr[i] != '\0'; i++)

There are of course other serious errors like no bounds checking anywhere. scanf("%s", addStr) is just as bad as gets().

Both the for loops are wrong actually. The first one should be:

Code:

for (i = 0; mainStr[i] != '\0'; i++)

instead of

Code:

for (i = 0; totalStr[i] != '\0'; i++)

Also, see this: Cprogramming.com FAQ > Why fflush(stdin) is wrong

Code:

for (i = 0; mainStr[i] != '\0'; i++)
        {
            totalStr[i] = mainStr[i];
        }
        totalStr[i] = ' ';
        for (j = 0; addStr[j] != '\0'; j++, i++)
        {
            totalStr[i+1] = addStr[j];
        }
        printf("%s", totalStr);

It prints out "abc qwTHR-MINGW32"

I entered "abc" as the first string and "qw" the second string. Thanks for helping.

Sorry for the indentation style, Actually thee code was so because i copied and pasted right away. But the actual code indentation is fine.