Help needed for c programming only

[zhengkoon8]

Please help me to check my coding where the mistake is and correct it for me. Thank you for the help. I need c programming coding only.

Question:
Write down a function getint() , which would receive a numeric string from the keyboard, convert it to an integer number and return the integer to the calling function. A sample usage of getint() is shown below:

#include <stdio.h>
int main ()
(
int a;
a=getint();
printf(“you entered %d\n”, a);
return 0;
}

My answer:

#include <stdio.h>
#include<string.h>
#define num 50
void getint()
{
	int i,j;
	char cha1[50];
	char cha2[num][50];
	printf ("Please enter the number:(Enter 'endtext' when finish.)\n");
	scanf ("%s",&cha1);
	printf ("1");
	while (strcmp(cha1, "endtext")!=0)
	{
		cha2[i]=cha1;
		i++;
		scanf ("%s",&cha1);
	}
	for (j=0;j<=i;j++)
	{
		if (cha2[j]==0)
		{
			printf ("%s ",cha2[j]);
		}	
		else if (cha2[j]==0)
		{
			printf ("Please do not insert character.");
		}
		else
		{
			printf ("Please do not insert special symbol.");
		}
	}	
}
int main ()
{
	int a;
	a=getint();
	printf("you entered %d\n", a);
	return 0;
}

[Adak]

fgets() will get the char string for you, much easier than what you have - 1 line.

C has standard functions for converting alpha char's to numbers, why not use them? One line, and you're done. Check out atoi() (short for "alpha to integer"), and related functions in the C language.

It seems like you're fighting the language here, rather than using it. It's fine to work out your own way of doing this, but 1) it doesn't work, and 2) it's just not good code, imo.

[zhengkoon8]

Thanks Adak. Because I just learn the C programming this two months. So I only learn so basic like string, array and so on. So I still do not know got the code of atoi(). I will look at it and try my code. Thanks for the help.

[Adak]

atoi() is part of stdlib.h, so include that header file

I haven't run this code, but I believe it's OK:

#include <stdio.h>
#include <stdlib.h>

int main(void) {
  int number;
  char *string = {"12345"};
  
  n = atoi(string);
  printf(" My string is: %s, and my number is: %d\n", string, number);


  return 0;
}

//Watch your overflow with atoi(). If that happens, the result is undefined.

Be sure any string you use with atoi(), (like with all string functions), is a REAL string, and has been given (or you have assigned to it), an ending char of '\0' - the end of string character.

Any bunch of letters without that end of string char, is just a bunch of letters, **NOT** a string, in C.

[zhengkoon8]

Oh. The code is use like that. Ok. Thanks for the help. Then how the getint () code function??? As I not sure how it works.

[Adak]

int i,j;
	char cha1[50];
	char cha2[num][50];
	printf ("Please enter the number:(Enter 'endtext' when finish.)\n");
	scanf ("%s",&cha1);
	printf ("1");
	while (strcmp(cha1, "endtext")!=0)
	{
		cha2[i]=cha1;
		i++;
		scanf ("%s",&cha1);
	}

When I saw i being incremented, without having ever been assigned a starting value, I just stopped reading the code -

such code is just not up to the standard I set.

I can't stand to read it.

If you want to use this function, let me know - I'll disappear from your thread.

[zhengkoon8]

Don't disappear from my thread. I need to learn to be better programmer so that i can program such a good code as u did. Thanks for the help anyway.

[zhengkoon8]

Adak, can u recommend me to study which programming book to improve my coding standard????? Thanks.

[Tool]

http://en.wikipedia.org/wiki/The_C_P...anguage_(book)

Join the club.

[Elysia]

Adak, do PLEASE avoid bad practices when showing code. Use const char* with string literals.
And it's better to use strtol rather than atoi. How do you use them? That is what documentation is for. For example, just googling strtol should yield lots and lots of results. Have you tried that already?

[zhengkoon8]

I will try it Elysia. Thanks for the suggestion also. I can learn more by trying more coding. And thanks for the Tool that suggest me the book. Thank you very much.

[Adak]

Elysia, you use const* for string literals, because on your system, they ARE sting literals. As you know, on my compiler, they are NOT.
So naturally, I don't use const* for those string literals. I only do that on compilers where they ARE constant.

You can call it a "bad practice" until the cows come home - but I'm WAY too pragmatic to call something something it is not, or change something that works perfectly.

atoi() worked perfectly. I can't say "don't use atoi() because it might fail", when it's working perfectly. Any C function can fail if it's not used correctly.

Z man, here's the book for you: (cheaper and better for you):

Author: Ivor Horton, Title: "Beginning C"

It is for beginners, but it will take you a very long way, with lots of excellent examples of how to solve a real life puzzle or problem, with your programming.

For a beginner, it's way better than K&R's white book - that one's for coder's with a bit of experience.

[jeffcobb]

Only it was to take an integer such as 32768 and reverse it using NO string methods...so the output would be 86723....only question that I had to scratch my head over....good test of thinking but not the kind of stuff I have to do day-in and day-out (CellBE system software)....

[laserlight]

Elysia, you use const* for string literals, because on your system, they ARE sting literals. As you know, on my compiler, they are NOT.

Nah, they are string literals either way. Rather, on your system and compiler toolchain, the undefined behaviour that results from modifying a string literal happens to be implemented in a sensible way and is documented as a usable feature.

So naturally, I don't use const* for those string literals. I only do that on compilers where they ARE constant.

It may be the case that it is the case for zhengkoon8's compiler.

You can call it a "bad practice" until the cows come home - but I'm WAY too pragmatic to call something something it is not, or change something that works perfectly.

It is not pragmatic to rely on undefined behaviour when it is rather easy to get away without undefined behaviour... unless you know for certain that the given compiler where the undefined behaviour is documented as expected will always be used, but this is certainly not the case for an example in a forum dedicated to C programming in general.

[zhengkoon8]

Thanks Adak for the suggestion.