hi everyone,
i wrote this little piece of code, because mostly i got sick of my TA not being able to read my code.
i code using VI w/ a tabspace of 4, he opens it and the editor defaults to 8, w/h makes my code look like something out of the obfuscation contest.
anyhow...simple piece of code....takes 3 cmd line args. input file, output file and size to tab.
it replaces each '\t' character w/ a number of spaces.
any idea on improventes or comments are welcome.
curiousity killed the cat, but it
makes for one hell of a programmer.
Alien.
Be careful with
First of all you don't need comments here. Everyone can see your checking for EOF. Most people code this asCode:char c; while((c = fgetc(in))) { if (EOF == c) { break; } }
As the break statement looks ugly there. It should beCode:int c; while((c = fgetc(in)) != EOF) { }
int c as char's arn't guranteed to be signed. If char's are
unsigned and as EOF is negative = -1 on linux this can cause problems.
>on linux this can cause problems
On any system this will cause problems for the reason you stated.
-Prelude
Last edited by Prelude; 03-03-2002 at 07:34 AM.
My best code is written with the delete key.
Itīs a style question:
just turn
intoCode:if ('\t' == c) { for (count = 0; count < tab; count++) fputs(" ",out); }
andCode:if (c == '\t') for(count = 0; count < tab; count++) fputs(' ',out);
intoCode:if (EOF == c) { break; }
Itīs more common, more readable and prevents misstakes.Code:if (c == EOF) break;
I also wonder if
fputs(" ",out);
works like expected. I would rewrite it as
fputs(' ',out);
klausi
Last edited by klausi; 03-03-2002 at 11:42 AM.
When I close my eyes nobody can see me...
