Send() not "sending" whole message

Code:

---

printf("\nPlease enter username : ");
                                        scanf( "%s", &username);
                                        printf("Please enter password : ");
                                        scanf( "%s", &password);
                                        send(sockfd, &username, strlen(&username), 0);
                                        break;

---

Can anyone see why this code is sending all but the first character?

How is "username" declared? Your use of & in all three cases here is not appropriate if these are just normal char pointers.

You don't need the & for scanning into an array / pointer. Also, you probably want to print your input just to be sure it's what you think it is:

Code:

---

scanf( ... )
printf( "debug: \'%s\'\n", username );

---

Quzah.

If your compiler is not complaining about strlen(&username), you've got your types wrong (or you forgot to #include <string.h>). If your compiler is complaining about strlen(&username), you should fix the problem; don't ignore warnings from a compiler, as they tend to be useful.

At the very least, you should remove all those ampersands. They cannot be right (except possibly the &username in send() is acceptable, but even then you can drop it). Without seeing all of your code, though, I can't definitively say what's going wrong. It'd be really helpful to see the declarations of username and password, at least.

Code:

---

    char *username;
    char *password;

---

Code:

---

    printf("\nPlease enter your new username : ");
                                        scanf( "%s", username);
                                        printf("Please enter  your password : ");
                                        scanf( "%s", password);
                                        send(sockfd, username, strlen(username), 0);
                                        break;

---

When run like this, as soon as i press enter after inputting the user name I get a segmentation fault.

You didn't actually allocate space for either pointer, did you?


Quzah.

Sorry, I am quite new to C and have not quite got to grips with the pointer stuff.

Originally I had

Code:

---

    char username;
    char password;

---

Code:

---

    printf("\nPlease enter your new username : ");
                                        scanf( "%s", &username);
                                        printf("Please enter  your password : ");
                                        scanf( "%s", &password);
                                        send(sockfd, &username, strlen(&username), 0);
                                        break;

---

But that read in all the text, however long just missing of the first character.

Code:

---

char justonecharacter;
char *pointertoacharacterbutnoactualallocatedmemory;
char arrayofXelementsofactualallocatedspace[ X ];

---

If you're using a pointer, then you need to make it point some place. That means you need something like malloc.


Quzah.

Thanks! I've now declared them, for example :

Code:

---

    char string[50];

---

is this bad practice?

Quote:

---

Originally Posted by Martin_T

is this bad practice?

---

No, but then you will want to restrict the amount of input in the scanf line so you cannot overflow -- scanf("%49s") or something.