Thread: Character string help

I cant seem to get this to work. Keep getting weird output. No clue how to fix it. Can someone help me please?

Code:

#include<stdio.h>
#include<conio.h>
#include<string.h>

main()
{
      char name[10];
      char name1;
      int j,score,sum,avg,ducknum,abvavg;
      
     
      int a[5];
      abvavg = 0;
      ducknum = 0;
      sum = 0;
      for(j = 1; j < 3; j++)
      {
          printf("Please enter the name\n");
          scanf("%s",&name1);
          printf("Enter score\n");
          scanf("%d",&score);
          name[j] = name1;
          a[j] = score;
          sum = sum + score;
      }
      avg = sum / 4;
      for(j = 1; j < 5; j++)
          {
          
           if(a[j] > avg)
           {
            abvavg = abvavg + 1;
           }
		   if(a[j] == 0)
		   {
            ducknum = ducknum + 1;
           }        
           if(a[j] > 50)
           {
            printf("%c hit above 50 with a score of %d\n",name[j],a[j]);
            } 
          }
        printf("The amount of batsmen who made a duck is:%d\n",ducknum);
        printf("The amount of batsmen who scored above the team average is:%d\n",abvavg);
        printf("The average is:%d\n",avg);
        getch();
}

name1 is just a char, not a char array[]. You can't fit an entire name into a one char variable. The printf() for name1 should be %s, after you make name1, into name1[20].

Also remember that arrays start at position '0'. In your code, a[j] (and the names when you fix them) will skip the first place and start at the second position (i.e. '1'). Just worth bearing it in mind.

Thanks alot guys. You helped me to correctly output the names. But now the program seems to output the name that was entered last with the correct score even if they're not associated with each other.

Example, I could input the following:

John - 54
Max - 32
Luke - 12
Dan - 23

The program will output
Dan scored above 50 with a score of 54.

John should have been outputted. Can someone help with this please?

Code:

#include<stdio.h>
#include<conio.h>
#include<string.h>

int main(void)
{
      char name[10];
      char name1[20];
      
      int j,score,sum,avg,ducknum,abvavg;        
      int a[5];
      
      abvavg = 0;
      ducknum = 0;
      sum = 0;
      
      for(j = 0; j < 3; j++)
      
      {
          printf("Please enter the name\n");
          scanf("%s",&name1);
          
          printf("Enter score\n");
          scanf("%d",&score);
          name[j] = name1;
          a[j] = score;
          sum = sum + score;
      }
      
      avg = sum / 4;
      for(j = 0; j < 3; j++)
          {
          
           if(a[j] > avg)
           {
            abvavg = abvavg + 1;
            }
		   if(a[j] == 0)
		   {
            ducknum = ducknum + 1;
            }       
           if(a[j] > 50)
           {
            printf("%s hit above 50 with a score of %d\n",name1,a[j]);
            }
          }
        printf("The amount of batsmen who made a duck is:%d\n",ducknum);
        printf("The amount of batsmen who scored above the team average is:%d\n",abvavg);
        printf("The average is:%d\n",avg);
        getch();
        return 0;
}

Doesn't this give you a compiler error?

Code:

name[j] = name1;

Compiler warnings and errors are very helpful--even if they seem unintelligible at first.

I always try to solve the first one first, because sometimes a single error can confuse the compiler and result in 50 error messages.

Also, sometimes you get an error message and the program doesn't even compile. But if it compiled previously, you may have the previous executable still present. So if you ignore the errors, you may be executing the old executable. That can be very confusing, since it will continue to fail the same way regardless of what changes you make in the code.

Ok so I implemented strcpy. Can someone show me how to do the two dimensional array for the names?

Code:

#include<stdio.h>
#include<conio.h>
#include<string.h>

int main(void)
{
      char name[10];
      char name1[20];
      
      int j,score,sum,avg,ducknum,abvavg;        
      int a[5];
      
      abvavg = 0;
      ducknum = 0;
      sum = 0;
      
      for(j = 0; j < 3; j++)
      
      {
          printf("Please enter the name\n");
          scanf("%s",&name);
          
          printf("Enter score\n");
          scanf("%d",&score);
          
          a[j] = score;
          strcpy(name1,name);
          sum = sum + score;
          
          }
          
          
      
      
      avg = sum / 4;
      for(j = 0; j < 3; j++)
          {
          
           if(a[j] > avg)
           {
            abvavg = abvavg + 1;
            }
		   if(a[j] == 0)
		   {
            		ducknum = ducknum + 1;
            	   }    
			if(a[j] > 50)
           		{
            			printf("%s hit above 50 with a score of %d\n",name1,a[j]);
            		}   
           
          }
        printf("The amount of batsmen who made a duck is:%d\n",ducknum);
        printf("The amount of batsmen who scored above the team average is:%d\n",abvavg);
        printf("The average is:%d\n",avg);
        getch();
        return 0;
}

Ok thanks ALOT guys. It works good now. LAST problem i promise. I really dont know how to read strings with a space. Like if i enter John Brown. It messes up. Can only store One string at a time. The white space causes problems. Advice on getting around this?

Originally Posted by key4life

LAST problem i promise.

There's never a last problem. Really.

Originally Posted by key4life

I really dont know how to read strings with a space. Like if i enter John Brown. It messes up. Can only store One string at a time. The white space causes problems. Advice on getting around this?

scanf() stops at a space, but fgets() doesn't.

If you don't mind risking a crash on a buffer overrun, you could alternately use gets().

Well when i run this now, after the first input of name it works fine. then after i input a score it jus skips the next name scan (outputs the prompt tho) then prompts for the next score.

Code:

#include<stdio.h>
#include<conio.h>
#include<string.h>
#define array_SIZE 3
#define str_SIZE 20
int main(void)
{
         
      char name[SIZE][str_SIZE];     
      int j,score,sum,avg,ducknum,abvavg;        
      int a[SIZE];
      
      abvavg = 0;
      ducknum = 0;
      sum = 0;
      
      for(j = 0; j < SIZE; j++)
      
      {
          printf("Please enter the name\n");
          fgets(name[j],str_SIZE,stdin);
          
          
          printf("Enter score\n");
          
          scanf("%d",&score);
          
          a[j] = score;
          sum = sum + score;
          
      }
         
         
      avg = sum / SIZE;
      for(j = 0; j < SIZE; j++)
          {
          
           if(a[j] > avg)
           {
            abvavg = abvavg + 1;
            }
		   if(a[j] == 0)
		   {
            		ducknum = ducknum + 1;
            	   }    
			if(a[j] > 50)
           		{
            			printf("%s hit above 50 with a score of %d\n",name[j],a[j]);
            		}   
           
          }
        printf("The amount of batsmen who made a duck is:%d\n",ducknum);
        printf("The amount of batsmen who scored above the team average is:%d\n",abvavg);
        printf("The average is:%d\n",avg);
        getch();
        return 0;
}