Arranging an array ascendingly =x

[Ulti]

I know its prolly an easy question but i cant find what i did wrong in my code.
Its 1d array that i wanted it to rearrange
i/p numbers from user
o/p numbers in ascending order
The compiler gives me memory violation error.

#include <stdio.h>
#include <conio.h>
main()
{int x[100];
 int temp=0;
 for(int i=0;i<5;i++)
 {scanf("%d",&x[i]);}
 
  for(int i=1;i<5;i++)
   {

    if (x[i]<x[i-1])
    {
     temp=x[i];
     x[i]=x[i-1];
     x[i-1]=temp;
    }
}
for(int i=0;i<5;i++)
printf("%d",x[i]);
getch();

}

[Epy]

scanf("%d",x[i])

scanf("%d",&x[i])

Also, you're redeclaring i as an int several times, only declare it once. Set it back to 0 when needed.

main needs a type, preferably int, which means it also needs a return statement at the end.

[Ulti]

ty for replying..well disregarding the &x[i] i still did it and still same issue ..i guess there is a problem in the code itself, bah i am too tired xD...cant find the problem..it should work okay =x

[Ulti]

oh i solved it..but my algorithm to da program isnt correct =<..any hints?=x

[Adak]

#include <stdio.h>
#include <conio.h>

int main()
{  int x[100], i, j;
   int temp=0;
   for(i = 0; i < 5; i++)
     scanf("%d", &x[i]);
 
//  for(int i=1;i<5;i++)  
   for(i = 0; i < 4; i++)  //for this sort, we stop the outer loop index counter at max - 1
   {
      for(j = i + 1; j < 5; j++) //stop at max index
      {
          if (x[i] < x[j])
          {
              temp=x[i];
              x[i]=x[j];
              x[j]=temp;
    }
  }
  for(i = 0; i < 5; i++)  //removed duplicate declaration for i
     printf("%3d",x[i]);
  printf("\n\n\t\t\t     press enter when ready");
  getch();
  return 0;
}

Although it's now standard to allow variables to be declared anywhere in the function, it's still a great idea, to declare them all at the top of the function. You won't double declare any, and you won't be hunting around trying to find out all the variable names you've declared. Because they're all together, already.

It wasn't sorting because you left out the second for loop.