looping to get user input

[james123]

Hi all,

Second newbie question of the day! I'm building a program that gets input from the user. I am using scanf to get a line and then do some processing and this is working fine. The problem comes when I try to loop through this until the user enters 'quit'. It works fine the first time round but then just goes into an infinite loop. The code is below:

while (1) {

char expr[100] = {0};

printf("Input Expression:");
scanf("%[^\n]", expr);

if (strcmp(expr, "quit") == 0) { return 0; }

// do stuff here

printf("\n");

}

This has been simplified by removing some extra code that processes the input however I don't think this is where the problem lies. I think it's something to do with the scanf but am unsure what. Any pointers greatly appreciated!

Cheers,
James

[rags_to_riches]

Aren't you missing a type specifier in your scanf?

[james123]

I could well be... basically I want to read in one line of data, I thought that was how to read in one line? How would you suggest doing it?

[Memloop]

The way you've used scanf is inherently unsafe. See the FAQ for better methods: Cprogramming.com FAQ > Get a line of text from the user/keyboard (C)

[james123]

That did the trick, thanks alot! I've been tearing my hair out over this for ages!

James