problem with do-while loop and char

[sal]

THIS IS A PART OF MY PROG.. I M USING A DO-WHILE LOOP. i want e to b a character rather than an integer but when ever i try to run my prog with e as a character it doesnt work all the same... i did change the values in if condition to characters as well... can u plz tell me how to work this with e as a character????

printf("\n\n\nPress 1 to EXIT or 2 to CONTINUE : ");
scanf("%d",&e);
if (e==1)
break;
else
printf ("error: incorrect input");
}
while (e==2);
getch();

[Kinshara]

a character? like when you input "exit", it would be exit? and "continue" it would continue?

[Elysia]

Start by fixing the errors first.
Do not use clrscr. It is non-standard.
You have failed to include proper headers for the functions you use.
You lack prototypes of your custom functions.
main must always return int.
Some of your functions lack a return type.
Finally, your indentation sucks. You must address that.

[sal]

like when i press Y the prog continue n when i press N it stops

[sal]

@elysia.... there r no errors... it runs smoothly.... i just want e to work with characters.... thnx for the advice though ill work on them

[Adak]

When scanf() pulls in a char, it leaves a newline char behind. It does the same thing for numbers.

Whitespace, like newline char's, are skipped over by scanf(), when it's looking for a number for input.

For char's, scanf() will not skip over a newline char - it will accept the newline as valid input, and make your program act nutty.

Common problem, by the way. To stop it, add in a

myVariable = getchar() right after the scanf() line of code. Obviously, don't use the variable you just got from the user for this. If you have to use a garbage variable, do that. (I call mine "gar" for short, when I need it).

The variable can be a char, or an integer, it doesn't matter. It just needs to pull the newline char, off of the keyboard's buffer.

No fflush(stdin) won't work - that only works on output buffers, not input.

[Kinshara]

you can make the variabel into char type..
so, you use %s when you scan,, or you can use getch(include<conio.h>)
after that, you use if to select which one is true
eq,

char s;

s=getch();
if(s=='y'||s=='Y')
{blablabla}
else if(s=='n'||s=='N')
{blablabla}

actually it's so much way to make that, but it is one of them..
hope it work.. ^^

[sal]

thanx alot pple.... adak ur way worked out.. kinshara the thing is i cant make things work quite the way i wanted to with if statement thanx though... THANKS A MILLION EVERY1

[Elysia]

You THINK it works, but it all honestly, what you do is bad practice.
Put the code inside a C++ compiler or turn up the warnings on your C compiler.
It will list a lot of things you should fix.
Remember: just because it runs does not mean that it is RIGHT.

[sal]

k elysia i dont knw how to indent it ane better but i have added to prototypes, wat did u mean main must always return int.
Some of your functions lack a return type???

[Elysia]

Indentation: it is called google. For example: Indent style - Wikipedia, the free encyclopedia

main returns int:
You have: void main()
Should be: int main()

Some functions lack return type:
You have: root ()
Should be int root()

[sal]

im having another problem just saw it... the root function im want it to return a float value to main... how do i do that cuz no matter what value i enter the answer give 0.0000 ...????

[Elysia]

Then declare it to return float.

[sal]

hey thaanx... that did do the trick.....