What is wrong with my code?

[yann]

Hi, this code should make a c file(it wont compile it) by my preferences...

#include <stdio.h>
#include <string.h>

#define txt ".txt"
#define dat ".dat"
#define c ".c"
#define cmd1 "electropulse"
#define cmd2 "weight"
#define cmd3 "exit"
#define cmd4 "phi"
#define cmd5 "pi"
#define cmd6 "time"
#define cmd7 "print"

int var[100];
int var2[100];
int searchn = 0;
int lookn = 0;
char pn[100];

FILE *f;


//look for
int ep(){
    	fprintf(f, "int ep(){\n search for eps\n }\n");
    	return;
}

int we(){
    	fprintf(f, "int we(){\n   measure weight;\n   return;\n   }\n");
    	return;
}


//search for
int phi(){
	fprintf(f, "int phi(){\n    search for phi;\n  return;\n   }\n");
	return;
}

int pi(){
	fprintf(f, "int pi(){\n    search for pi;\n    return;\n   }\n");
	return;
}
int e(){
	fprintf(f, "int e(){\n    search for e;\n   return;\n   }\n");
	return;
}

//body
int pre(){
	fprintf(f, "#include <stdio.h>\n #include <string.h>\n\n");
	return;
}

int m(){
	fprintf(f,"int main(){\n");
	if(var[0] == 1) { fprintf(f, "ep();"); }	
	if(var[1] == 1) { fprintf(f, "we();"); }
	if(var2[0] == 1) { fprintf(f, "(phi);"); }
	if(var2[1] == 1) { fprintf(f, "(pi);"); }
	if(var2[2] == 1) { fprintf(f, "(e);"); }	
	fprintf(f,"}\n");
	return 0;
}




int main() {
	printf("Project name: ");
	scanf("%27[a-zA-Z0-9_-]", pn);
	strcat(pn,c);
	f = fopen(pn,"w");
	pre();
	while(pn != cmd3 || searchn<2){    	
	printf("search for\n");	
	scanf("%27[a-zA-Z0-9_-]", pn);	
	if(pn==cmd1){
        ep();
	var[0]=1;    	
	}
	if(pn==cmd2){
        we();
	var[1]=1;	
	}
	searchn++;	
	}
	while(pn != cmd3 || lookn<2){    	
	printf("look for");	
	scanf("%27[a-zA-Z0-9_-]", pn);
	if(pn==cmd4){
        phi();
	var2[0]=1;    	
	}
	if(pn==cmd5){
	pi();
	var2[1]=1;
	}
	if(pn==cmd6){	
	e();		
	var2[2]=1;	
	}
	lookn++;	
	}	
	m();
	fclose(f);
	return 0;
}

But something is wrong in the red part, instead of waiting for my input, it goes to infinite loop, anyone can help me?

[quzah]

If it won't compile, why not? Compile with warnings and errors turned on.


Quzah.

[yann]

o, MY(this) program does compile with no errors, but it makes another c file, which is another story...

[quzah]

Of course it makes a c file. You're telling it to:

#define c ".c"
...
	strcat(pn,c);
	f = fopen(pn,"w");

What did you expect?


Quzah.

[yann]

I know it does... But, read my first post, there aren't any problems with that, the problem is somewhere here:

	while(pn != cmd3 || searchn<2){    	
	printf("search for\n");	
	scanf("%27[a-zA-Z0-9_-]", pn);	
	if(pn==cmd1){
        ep();
	var[0]=1;    	
	}
	if(pn==cmd2){
        we();
	var[1]=1;	
	}
	searchn++;	
	}

This goes to a infinite loop of printing "search for" but it shouldn't...

[MK27]

==, !=, etc are numeric comparisons -- so when used with a char pointer, the addresses are compared, not the strings.

To compare strings, use strcmp:

while((strcmp(pn,cmd3) !=  0) || (searchn<2))

[yann]

OK, but still I have the same problem)=.

[quzah]

I know it does... But, read my first post, there aren't any problems with that, the problem is somewhere here:

Make up your mind!

First you said... "It doesn't compile..."
Then you said... "Oh wait, no it does. But it's not making the right file, it's making a .c file and that's wrong!"
Then you said... "No, wait, that's right, but something else is wrong!"

Learn to ask smart questions! How To Ask Questions The Smart Way


Quzah.

[MK27]

OK, but still I have the same problem)=.

This is where those "printf" statements come in handy for debugging:

printf("\npn=\"%s\"\n"),pn);   fflush(stdout);

put that at the beginning of the loop so you can see what's happening.

[yann]

Make up your mind!

First you said... "It doesn't compile..."
Then you said... "Oh wait, no it does. But it's not making the right file, it's making a .c file and that's wrong!"
Then you said... "No, wait, that's right, but something else is wrong!"

Learn to ask smart questions! How To Ask Questions The Smart Way


Quzah.

Well, maybe you didn't understand me in a proper way, I said "it makes a c file(it doesn't compile IT)" I didn't said that my program doesn't compile...

[quzah]

Ok, so it still remains that you didn't explain your issue at all. You didn't say what it was supposed to do compared to what actually happens. If you have a problem, you need to say:

"I'm trying to do _this_ but _this_ happens instead."

You also want && not ||.


Quzah.

[yann]

Well, pn is still name.c, because I haven't changed it yet, what is wired is that program doesn't stop when it gets to scanf function, or when the searchn is higher than 2...

[quzah]

Well, pn is still name.c, because I haven't changed it yet, what is wired is that program doesn't stop when it gets to scanf function, or when the searchn is higher than 2...

That's because you used OR.


Quzah.

[yann]

Yes, now I fixed that, but it still skips my input...

[quzah]

So where's your revised code? Post a short version without all those function calls that we don't care about. Put in some printf statements to show what your actual variables and input are showing at the area you get stuck. Seriously, you need to ask questions wisely, and learn to debug, even if it's just by using printf. My guess is it doesn't like what you're typing (your scanf isn't doing what you expect), or there's a newline stuck in your input.


Quzah.