Triangle Question

[DJ_Steve]

Hello, I'm currently working on a program that reads in 3 numbers then tells you what triangle it is or if its invalid

I'm pretty much nearly finished except I need help on 2 things

#include <stdio.h>

int main()
{
    int side1 = 0;
	int side2 = 0;
	int side3 = 0;

    while(side1 != 'q')
    {
    printf("Please input the length of the Triangle Sides\n");
    printf("Side A: ");
    scanf("%d", &side1);
    printf("Side B: ");
    scanf("%d", &side2);
    printf("Side C: ");
    scanf("%d", &side3);

			if (side1>side2){
				if (side2==side3)
				printf("Your triangle is Isoceles.\n");
			}
			if (side1 == side2){
				if (side1 == side3)
				printf("Your triangle is Equilateral.\n");
			}
			if (side1 != side2){
				if (side2 != side3)
				printf("Your triangle is Scalene.\n");
			}
            else
            printf("Not a valid Triangle!\n");
    }
    return(0);
}

1) Whenever I input three equal numbers the message comes up "Your Triangle is Equilateral" but then on the next line it says "Not a valid Triangle".

This doesn't happen for the others though...

2) Is possible to make it the program loop forever until the user inputs 'q' at any time? At the moment it only quits when the user inputs q for side1


Thanks for any advice!

[quzah]

If you only plan on checking one thing, you need an else statement for every if.

if X
else
if Y
else
if Z
else...

Quzah.

[Elysia]

2) Yes. It is possible. All you need to do is incorporate some logic for looping until the user wants to quit.

[DJ_Steve]

Ok, I just put if statements for 'press q at any time' but im still having the same problem with an Equal Triangle

[aaa111]

The reason it is not working is because any else is related to its nearest if.So the else in you program is related to the last if statement and since it bacame false the else executed.You should create an else-if chain to work this properly.

#include <stdio.h>

int main()
{
    int side1 = 0;
	int side2 = 0;
	int side3 = 0;
	
    while(side1 != 'q')
    {
    printf("Please input the length of the Triangle Sides\n");
    printf("Side A: ");
    scanf("%d", &side1);
    printf("Side B: ");
    scanf("%d", &side2);
    printf("Side C: ");
    scanf("%d", &side3);

			if (side1>side2){
				if (side2==side3)
				printf("Your triangle is Isoceles.\n");
			}
			else if (side1 == side2){
				if (side1 == side3)
				printf("Your triangle is Equilateral.\n");
			}
			else if (side1 != side2){
				if (side2 != side3)
				printf("Your triangle is Scalene.\n");
			}
            else
                printf("Not a valid Triangle!\n");
    }
    return(0);
}

Also you are taking a char input for an integer variable to break the loop which make it an infinite loop.

[abachler]

Thanks for any advice!

A , B , C are the sides

if((A + B + C) < __max(__max(A , B) , C) * 2) printf("Invalid Triangle\n");

[DJ_Steve]

ahh thanks for the help!

Its all sorted now