Printable View
If I'm trying to read untill end of file, using fgets(), and somewhere inside the loop, let's say fgets fails. (Which means we got a read-error).
What would be the most correct thing to do if that occur?
Can I try using fgets() again and again, and hope it can work again?
Or can I try using fgets() again and again at an error, but perhaps with a max-counter?
Or do I have to stop all reading, and close the file?
You can check feof and ferror to see what's what. If it's eof, then you do whatever you want to do at eof (since that's what was supposed to end your loop anyway, right?) -- if this is common that you get eof in the middle of your loop, then either your file isn't built the way you think it is or your loop test is incorrect (this is surprisingly common). If there's ferror, then I don't know that continuing is possible (I think for sure you would have to do the clear-error function that I've forgot the name of).
Well, no trying again and again. What if for some reason you cannot read from the file? You will have an infinite loop. A max_counter is a good idea, with the counter reseting maybe when fgets() succeeds?
There is no correct or wrong thing to do. Trying again after an error or not trying again or how many times to try is completely up to you. Depends on the program and its requirements
In my opinion, the correct thing to do is inform the user that there was an error reading the file, then exit the program. It's not really much use trying to reopen and re-read the file since your program has no way of knowing what's wrong.
Better to tell the user there's a problem. The user can then try to figure out why the file isn't readable and re-run your program if desired.
The general thing to do is:Quote:
Originally Posted by brewbuck
1. Check for error
2. Inform the user, or a log file
3. Repeat N times
Now, how many times to repeat depends on the read-errors possible, the time each error needs etc etc. Don't really see why it is correct for you to choose N=0 or N=10 or something else. It depends....
Is it failing because it's expected to? (Are you reading until it fails, which indicates you've reached the end of the file?) Or is it failing because of something else? It depends on your usage of it really.
I assume you actually are planning on having some way to tell when you're done reading? If you meet that condition, then you're done, and everything is fine. If not, then you should let them know that something went wrong.
All of this has been said, and it really is that simple. Basically if it's OK for it to have failed, continue as normal, otherwise, do something else.
Quzah.
You almost had it. :) clearerr()Quote:
(I think for sure you would have to do the clear-error function that I've forgot the name of)
I think a reasonable thing to do would be to see if an error occurred or whether it was just EOF; then you can decide whether to continue the program or exit.
To be honest, most programs probably just assume the end of normal input is reached and continue execution. (Assuming you didn't read part of a record or something from the file.)
In case of a hardware error like disk failure etc. you won't be able to proceed, so examine the error returned before trying ad nauseum.