Thread: My First C Program - Checking for compliance

Hello,

I've mostly programmed/scripted in VB and I want to learn better/proper techniques. I've written a very simple program and wanted to make sure it's standards compliant. I'm using VS2008 C++ for a compiler.

Code:

#include <stdio.h>

int pause(), add(int one, int two);

main(){
	int a;
	int b;
	int result;
	
	printf("Please enter a number: ");
	scanf("%d", &a);
	fflush(stdin);

	printf("Please enter another number: ");
	scanf("%d", &b);
	fflush(stdin);

	result = add(a, b);
	printf("The number you entered is: %d\n",result);
	pause();
	return(0);
}

int pause(){
	char move_on;
	printf("Thanks for playing, press enter...");
	//Won't move on until enter is pressed, doesn't work with just any key
	move_on=getchar();
	fflush(stdin);
	return(0);
}

int add(int one, int two){
	int sum;
	sum = one + two;
	return(sum);
}

Please let me know if I seem to be on the write track, of if I'm doing something that would be considered bad technique or out of standards.

Thanks,
Kyle

You can always turn up the warnings to high, which will note the lack of "int" before "main" and maybe the use of fancy // comments in a C file (depending on which standard).

Things that are not "standards compliant" but that you probably won't get warnings for are the use of fflush(stdin), which the standard does not give a meaning to but MS does, and your assigning the result of getchar (which is an int) into a char variable.

Things to note is that while your comment is more-or-less correct, it's not because of anything you do. That is, the reason you have to type enter is not some magic of getchar, it's just that that's the way input works -- you never see input until the enter key is pressed. (Also the fact that I can talk about "the comment" is worrisome as well.)

I've made main:

Code:

int main(void)

I'm trying to figure out the FAQ for flushing right now and will turn up my warnings. Thank you for the feedback!

Code:

#include <stdio.h>

int pause(), add(int one, int two), convert2int(char string[]);

int main(){
	char a[10];
	char b[10];
	char *p;
	int uno;
	int dos;
	int result;
	
	printf("Please enter a number: ");
	if (fgets(a, sizeof(a), stdin) != NULL)
	{
		if ((p = strchr(a, '\n')) != NULL)
			*p = '\0';
	}

	printf("Please enter another number: ");
	if (fgets(b, sizeof(b), stdin) != NULL)
	{
		if ((p = strchr(b, '\n')) != NULL)
			*p = '\0';
	}

	uno = convert2int(a);
	dos = convert2int(b);

	result = add(uno, dos);
	printf("The number you entered is: %d\n",result);
	pause();
	return(0);
}

int pause(){
	int move_on;
	printf("Thanks for playing, press enter...");
	//Get input until enter is pressed
	move_on=getchar();
	return(0);
}

int	add(int one, int two){
	int sum;
	sum = one + two;
	return(sum);
}

int convert2int(char string[]){
	int converted;
	converted = atoi(string);
	return(converted);
}

Is this better? Or what problems have I created now? Thanks again for your feedback.