Thread: How to read a txt file into an array

Originally Posted by Hitsugaya_KK

I am now getting an error based on "char retstr, [BUFSIZ];" . It is saying Error 2 error C2059: syntax error : '['

Post your current code, including the headers included.

Code:

#include <stdio.h> 
#include <string.h>
#include <sys/types.h>
#include <stdio.h>


struct item
{
           int ID;
           char name[64];
           int price;
};
int main(int argc, char *argv[])
{
           FILE *fp;
           char retstr[BUFSIZ];
           int *f1;
	   char *f2; 
	   int *f3;
	   char *p;
           int max_cnt=15;
           int i, cnt=0;

      	   struct item record [10];
	  
	 
	       if (fp=fopen("C://shoppinglist.txt","r"));
	       {
           printf("Error: can't open file.\n");
		   }
		   if( fp != NULL ) 
           {
           
           while( fgets(retstr, BUFSIZ, fp) != NULL )
           {

	       if ((p = strchr(retstr, '\n')) != NULL)
	       *p = '\0';
	       if(cnt == max_cnt)
	       break;

	       f1=strtok(NULL, " ");
	       f2=strtok(retstr, " ");
	       f3=strtok(NULL, " ");
	       strcpy(record[cnt].ID, f1);
	       strcpy(record[cnt].name, f2);
	       strcpy(record[cnt].price, f3);
	       

	       cnt++;
           }




	       
           exit(1);
           }
	


           for(i=0; i < cnt; i++)
           {


           printf("%d %s %d %d\n", record[i].ID, record[i].name,record[i].price,record[i].quantity);
  
           }

           fclose(fp);

 
           exit(0);
}

I was able to get read of the error by remobing "char retstr,[BUFFSIZ]; since it had already been initialized.

this is the next seop:

Code:

{
Int option;
int a; /*it lists all the items*/
int b; /* it looks for the item with the lowest price*/
int c; /* it discounts 20% of the price from all items only once*/
int d:/* it allows the user to select the items he wants and customise the quantity of each item*/

printf( "1 - view the complete list of goods in the shop, with their prices" );
printf( "2 – list the cheapest item on offer" );
printf( "3 – “discount” option" );
printf( "4 – choose items for purchase" );
printf( "5 – total price for items" );
printf( "6 - Exit");

switch ( option ) {
case 1:
case 2:
    break;
case 3:
case 4:
    printf( "choose item for purchase\n" );
    break;
case 5:
    printf( "total price for items\n" );
    break;
case 6:
    printf( "Exit\n" );
}

return 0;

I can only go so far in the second part

Code:

int menu_choice;



switch ( menu_choice) 
            {
            case 1: 
	                   for(i=0; i < cnt; i++) 	
	                   { 

                           printf ("%d %s %d\n", record[i].ID, record[i].name,record[i].price); 
	
	                   }

              case 2:    
                          cheapest item = record[i].price
	                   for(i=0; i < cnt; i++)
	                   {
		 
                           if (record[i].price < cheapest item)
	                   
         	           cheapest item = record[]i.name,record[i].price
                           }
 
              case 3:
	                   int discount = (record[i].price)x ((float)0.2 x (record[i].price)) 
   
		            for(i=0; i < cnt; i++)
				 
                           {
			    
                           printf("%s %d\n",record[i].name,discount);

                           }			

             case 4:       printf( "choose item for purchase\n" );
                               break;
        

             case 5:       printf( "total price for items\n" );
                                 break;
                
             case 6:       printf( "Exit\n" );
             }

return 0;
}

can someone help me with the option 4?

Your braces dont have matching end braces.

Originally Posted by Hitsugaya_KK

but I don't know how to make the user choose the item or even quantity. I know I have to use the integer ID from the array to allow the user choose, the question is how to code it.

Don't use the ID number. Print the array like a menu using a loop, and add an option number corresponding to the array index:

Code:

for (i=0;i<10;i++) print("choice %d - %s\n",i+1,array.name);

So the number entered by the user equals the array index of the item (+1, if you don't want to start with 0). These may end up being the same as the ID numbers -- but maybe not if you have sorted the array using some other criteria (eg, alphabetically). This way you do not have to search the array for anything.

Originally Posted by Hitsugaya_KK

Now the question is, how do I request the user to input the index with the aid of a scanf function?

scanf() is pretty straightforward but it has lots of little quirks. I recommend you write a short test program that you can keep separate from your projects and you can use that when you need to figure something out about scanf() -- this is much easier than doing it in your developing code and will save you time in the long run. I have directories full of short test things like this that I refer to and screw around with I need to figure out how something has to be done.

Code:

#include <stdio.h>
#include <string.h>

/* scanf() testing */

int main(void) {
	int i, x[3];
	for (i=0; i<3; i++) {
		printf("\nEnter a number: ");
		scanf("%d",&x[i]);
	}
	printf("\nYou entered %d %d %d\n",x[0],x[1],x[2]);	
	return 0;
}

Also: Don't write all this into the switch/case block. Use the switch to call functions which do the work and return relevant values. Otherwise you will end up with an overly long and awkward main() which does everything. Functions exist for a reason. Use them. Write them. Based on your specs, I would say you should have the one switch/case in main() and every single option should call a separate function.

Originally Posted by Hitsugaya_KK

Choosing the quantity for each of the items will make it harder to code. The number of items the person would like to choose should be up to 10 and the person should be able to stop choosing items at anytime during the process. Was thinking maybe there should be a confirmation option for if someone wants more items or not.

Part of the reason putting stuff in a function helps is that using functions add a level of "functionality". So for example you could have a loop in the case: block that calls the choosing function (and the choosing function returns the item chosen) with the confirmation option at the end of the loop to possibly break the loop.

Code:

	int x=0;
	while (x!=666) {
		printf("\nEnter a number: ");
		scanf("%d",&x);
	}

This will just repeating until you enter 666. So (to reiterate), you can use something like that in the case statement to call the choosing function, and then ask the user if they want to choose again.

x is an int, as is quantity, but in this part of your code, you're treating them like they're arrays.

Code:

		          printf("Enter a number: ");
				  
		          scanf("%d",&x[i]);
	              }

				  {
				  printf("Enter quantity for item\n");
				  scanf("%d",&quantity[i]);
				  }

				  {
				  printf("Do you want to choose more items? Yes[1] No[2]");
				  }

				  {
	              printf("You entered %d %d %d\n",x[0],x[1],x[2]);	
				  }

Your code is maddening to read through because of it's indentation style. Please find and follow
either a student/business style, or K & R style.

You do NOT need all those bloody curly braces, around every single line of your code!!
Curly braces go around everything in a function, and also surround any multiple line statements,
in a block of code. THAT IS ALL.

example:

Code:

if(you want more people to read your code, and your program to be better)
{
   use a decent indentation style
   more people will read it
   more people will assist you with it
   you will see more bugs, more easily, using this style
   others will see the bugs in your code easier as well
}

Because this if statement shows multiple dependent lines of "code" for it, it needs 
curly braces around them. Without them, only the first line of code would be 
part of the if statement.

You should be getting plenty of errors and warnings from your compiler. If you are not, then please adjust your
warning and error level for your compiler.