max and min of a list with sentenial at 0

Im having trouble with the smoothness of running this program. If you run it you will see the program right away. The program completes the task but uses a GetInteger function unnecessarily in the third line. Any help would be appreciated.

Here is the program
-------------------------------------
#include <stdio.h>
#include "simpio.h"
#include "genlib.h"

int main()
{
int n, min, max;

printf("Please enter a list of integers.\n");
printf("Signal the end of your list with 0.\n");
printf("Enter first number: ");
n=GetInteger();
{
min=n;
max=n;
while ((n=GetInteger())!=0)
{
printf("Enter next number: ");
if (n<=min)
min=n;
if (n>=max)
max=n;
}
printf("The maximum number in the list is %d.\n", max);
printf("The minimum number in the list is %d.\n", min);
}
}

I don't see any problem (although I don't know why you have a curly brace after your first call to GetInteger). Can you be more specific?


Also, we don't have simpio.h and genlib.h, so we can't run your program and help you debug those portions.

You posted this in the C forum, but your files are .cpp (C++) and they look like C. Are you doing C or C++?

And always use code tags. Surround your code in [ code ] and [ /code ] (without the spaces) and it will format your code nicely (different font, preserve spacing, etc).

Thanks for the tips. The problem is that GetInteger occurs when running the function unnecessarily at one point right after running the program. I believe it is a problem with the while statement but when i do

while (n!=0)

It fixes the first error but I get the minimum = 0 although that is just supposed to be the sentinel,

i will try to post in the c+ forums for help. Thanks again for the advice

Sounds very similar to this thread:

Finding smallest and second smallest integer and largest and second largest integer

Originally Posted by kbikkasani

Thanks for the tips. The problem is that GetInteger occurs when running the function unnecessarily at one point right after running the program. I believe it is a problem with the while statement but when i do

while (n!=0)

It fixes the first error but I get the minimum = 0 although that is just supposed to be the sentinel,

i will try to post in the c+ forums for help. Thanks again for the advice

The problem is that you are calling GetInteger twice the first time.

printf("Enter first number: ");
n=GetInteger();
{
min=n;
max=n;
while ((n=GetInteger())!=0)
{

You can fix this by removing the first getInteger altogether, as the while loop will not enter if you enter 0. But, you must first initialize n to 0 as your setting min and max to 0. Also, the curly brace after the first getInteger is not required.

Code:

int n= 0;
printf("Enter first number: ");
min=n;
max=n;
while ((n=GetInteger())!=0)
{

Thanks so much. Setting n=0 works perfectly. Thank you so much.