c program for sort and remove duplicate values from an array

Hi ,

I have a string array having a bunch of values. I need to sort this array, remove duplicate values from this array and reset the filtered array (without duplicate values) to a new array.

I am new to C programming. I have written some code, but it fails with a core dump always. Can some one please correct my code or send me an easy way to do this.

Thanks.

Code:

code snippet:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

main ()
{
int stat = 0;
int ctr = 4;
int inx = 0;
int status = 0;
int j = 0;
int k = 0;
int reset_count = 0;
char **lov_reset_values = 0;
char *str[] = { "test", "test1", "test2", "test" };

for ( inx = 0; inx < ctr; inx ++ )
{
printf ( "str[%d] = %s\n", inx, str[inx] );
}

for(j=0;j<ctr;j++)
{
status = 0;
for(k=1;k<=ctr;k++)
{
printf ( "entered after k= 0\n" );
if( strcmp (str[j],str[k] ) == 0 )
{
printf ( "matched\n" );
status = 1;
break;
}
}
if ( status == 0 )
{
if (reset_count == 0 )
{
printf ( "reset_count = 0\n" );
lov_reset_values = (char **)malloc( sizeof(char *));
}
else
{
printf ( "reset_count = %d\n", reset_count );
lov_reset_values = (char **)realloc( lov_reset_values, sizeof(char *)*(reset_count+1) );
}

lov_reset_values[reset_count] = (char *)malloc( sizeof( char )*(strlen(str[j])+1));
strcpy ( lov_reset_values[reset_count], (str)[j] );
printf ( "lov_reset_values[%d] = %s\n", reset_count, lov_reset_values[reset_count]);
reset_count = reset_count + 1;
}
}

printf (" reset_count = %d\n", reset_count );

/*
for ( inx = 0; inx < reset_count; inx++ )
{
printf ( "lov_reset_values[%d] = %s\n", inx, lov_reset_values[inx] );
}
*/

return stat;
}

Added code tags, but didn't help as the code lacks any indentation at all.
This needs to be fixed ASAP.

Here is the updated code with the indentation:
Here is the code with proper indentation:


#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

main ()
{
int stat = 0;
int ctr = 4;
int inx = 0;
int status = 0;
int j = 0;
int k = 0;
int reset_count = 0;
char **lov_reset_values = NULL;
char *str[] = { "test", "test1", "test2", "test" };

for(j=0;j<ctr;j++)
{
status = 0;
for(k=1;k<=ctr;k++)
{
if( strcmp (str[j],str[k] ) == 0 )
{
printf ( "matched\n" );
status = 1;
break;
}
}

if ( status == 0 )
{
if (reset_count == 0 )
{
printf ( "reset_count = 0\n" );
lov_reset_values = (char **)malloc( sizeof(char *));
}
else
{
printf ( "reset_count = %d\n", reset_count );
lov_reset_values = (char **)realloc( lov_reset_values,
sizeof(char *)*(reset_count+1) );
}

lov_reset_values[reset_count] = (char *)malloc( sizeof( char )*(strlen(str[j])+1));
strcpy ( lov_reset_values[reset_count], (str)[j] );
printf ( "lov_reset_values[%d] = %s\n", reset_count, lov_reset_values[reset_count]);
reset_count = reset_count + 1;
}
}

printf (" reset_count = %d\n", reset_count );
return stat;
}

Sorry, attached the file with the right indentation. Any help in fixing this issue of sorting and removing the duplicate entries from an existing string array and re-writing the filtered list to a different array, is appreciated.

Thanks.

First of all, use code tags (and be sure that your code is indented). Next, the easiest way to do this is:

Code:

1) create two arrays: 'a2' and 'a3'
2) copy the original array to 'a2'
3) qsort 'a2'
4) create a char*: 'last', set to an empty string (eg: "")
5) create two char**: 'c2' and 'c3' and set them to 'a2' and 'a3', respectively
6) loop
    6b) while the the string at 'c2' equals 'last' (use strcmp), increment 'c2'
    6c) copy the string at 'c2' to 'c3'
    6d) set 'last' to the string at 'c2'

Also I do not believe that you will ever check that status == 0? I would place some printf statements imediately after your inner loop. Check what values j and k are afterwards. Also your seg fault is do to you overstepping your array bounds with crt. Set k = 0 in your for loop, and have your for conditional check if the values or actually less than crt not less-than or equal-to.

Edit: Ooops! my bad.

Try coming up with an algorithm to solve this problem before diving into the coding process.