Thread: Beginner help

Hi,

I have just learned linked lists on C and want to write a program about it. But even this simple code gives runtime error which I added as attachment.

Could you help me about it, thanks...

The next pointer in head needs to be set to NULL after the first malloc:

head->next = NULL;

Originally Posted by Scarlet7

The next pointer in head needs to be set to NULL after the first malloc:

head->next = NULL;

Thanks, it works I missed it. But what about the dump value at the end of the list?

Originally Posted by Cooloorful

Why not just write out your values like this?

Code:

    while(current != NULL){
      if(current->coef != 0)
        printf("%dx%d+",current->coef,current->pow);
      current = current->next;
    }

Maybe but I just try the code to understand

Originally Posted by Cooloorful

Code:

    while(current != NULL){
      if(current->coef != 0)
        printf("%dx%d+",current->coef,current->pow);
      current = current->next;
    }

Ok, the blue sections are your code and won't be explained. The green is mine and I will explain.

When you are reading in the values you are taking in a final value with a coefficient of 0. You allow it in the list, but you technically only use it to let your program know when to stop reading in new values. Ok, that is fine. Given that fact, why even print something that is basically just a signal to stop reading? So the if statement checks if the coefficient is zero. If the coefficient is zero, the term is skipped.

OK It is the same but have you ever tried to run, when I attempt to exit, a dump value occurs at the end of the list

THANKS