Printf not printing all data

murjax · 07-20-2009, 01:53 PM

Quote:

Originally Posted by MK27

Whoops!

You should throw a printf, including the return value of fscanf, into the while loop so you can see what actually is happening.

More trash I see. It seems like it's printing the address of the variable instead of printing the value of the variable. Is it not reading the file properly?

tabstop · 07-20-2009, 01:57 PM

Quote:

Originally Posted by murjax

More trash I see. It seems like it's printing the address of the variable instead of printing the value of the variable. Is it not reading the file properly?

That's may well be because you're telling it to print the address of the variable. Make it print the value of the variable instead (like *EmployNum1, etc.).

murjax · 07-20-2009, 04:04 PM

Quote:

Originally Posted by tabstop

That's may well be because you're telling it to print the address of the variable. Make it print the value of the variable instead (like *EmployNum1, etc.).

That makes sense, except now I have the same problem I had before, printing the first 3 numbers correctly and then printing addresses for everything else.

MK27 · 07-20-2009, 04:25 PM

Quote:

Originally Posted by murjax

That makes sense, except now I have the same problem I had before, printing the first 3 numbers correctly and then printing addresses for everything else.

Is the return value of fscanf correct?

tabstop · 07-20-2009, 04:28 PM

Quote:

Originally Posted by murjax

That makes sense, except now I have the same problem I had before, printing the first 3 numbers correctly and then printing addresses for everything else.

Did I see code and/or an input file before? And what was the return value from fscanf? And are you printing inside or outside the while loop? And does your format actually match the text file you're reading? (For instance, if any of the pay rates are more than 10.00, or there's a space between the pay rate and the exempt character, then the answer is "no".)

murjax · 07-20-2009, 04:37 PM

Quote:

Originally Posted by MK27

Is the return value of fscanf correct?

It seems to be. Putting any other value in makes the printf statement print nothing.

MK27 · 07-20-2009, 04:44 PM

Quote:

Originally Posted by murjax

It seems to be. Putting any other value in makes the printf statement print nothing.

What I mean is something like this:

Code:

int retv;
retv=fscanf(....);
printf("fscanf scanned %d items", retv);

fscanf returns the number of items successfully read. So add that into your code and you will know whether it read 3 or 4 or 20. The condition of the while loop you posted earlier was just while(fscanf(...)) which is fine, but any positive number will pass that; it doesn't mean all 20 items were correctly scanned.

murjax · 07-20-2009, 04:48 PM

Quote:

Originally Posted by tabstop

Did I see code and/or an input file before? And what was the return value from fscanf? And are you printing inside or outside the while loop? And does your format actually match the text file you're reading? (For instance, if any of the pay rates are more than 10.00, or there's a space between the pay rate and the exempt character, then the answer is "no".)

There are spaces between every item in the file. Here are the contents of the file.

0101 41 8.11 Y 49
0722 32 7.22 N 40
1273 23 5.43 Y 39
2584 14 6.74 N 45

tabstop · 07-20-2009, 05:01 PM

Quote:

Originally Posted by murjax

There are spaces between every item in the file. Here are the contents of the file.

0101 41 8.11 Y 49
0722 32 7.22 N 40
1273 23 5.43 Y 39
2584 14 6.74 N 45

Then don't lie to scanf -- your format must match the data, or else the attempt to read the formatted data will fail. Your format promises that there are no spaces (you get the numbers okay since %d and %f will skip spaces automatically -- but %c won't, and thus you are doomed to failure from then on). Put spaces in your format where spaces appear in your data.

murjax · 07-20-2009, 09:33 PM

Quote:

Originally Posted by tabstop

Then don't lie to scanf -- your format must match the data, or else the attempt to read the formatted data will fail. Your format promises that there are no spaces (you get the numbers okay since %d and %f will skip spaces automatically -- but %c won't, and thus you are doomed to failure from then on). Put spaces in your format where spaces appear in your data.

Ok now it works. Thanks.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
I have some questions :(	geekrockergal	C Programming	19	02-01-2009 09:44 AM
whats wrong with this?	petedee	C Programming	32	01-06-2004 10:28 PM
error in program????	SpEkTrE	C Programming	5	11-24-2003 06:16 PM
Contest Results - May 27, 2002	ygfperson	A Brief History of Cprogramming.com	18	06-18-2002 01:27 PM
Warnings, warnings, warnings?	spentdome	C Programming	25	05-27-2002 06:49 PM