Networks Project fopen (input filename)

Hi there sorry if this is a repost, I am in a networking course and have a question (with many more to come).

First off a little bit about the proj, its an FTP stop and wait program.
As of right now I have created the sockets and have been able to connect and send txt. No I am trying to send data. My first step is taken a file name inputted by the user. Question is do i ask for filename or filepath

Code:

  
printf("Please enter the name of the file: ");
    
    bzero(filename,256);
    fgets(filename,255,stdin);
    
   
      if ( (in=fopen(filename,"rb")) == NULL )
        {
          printf("Could not open %s", filename);
          exit(1);
        }
      else
    	  printf("File exists.");

It depends...If you know your process will not change its working directory, and the files will be relative to that location, then ask for a filename. Other then that you should probably get the full path to the file. You can also ask for a filename if all file selections will be relative to some pre known directory.

Code:

    bzero(filename,256);
    fgets(filename,255,stdin);

fgets() will terminate the string with a \0 -- there is no need to bzero() the buffer here. Furthermore, you can pass 256, if that's the actual size of filename.

bzero()? Let me guess, you're using some coding tutorial written by an El1t3 H4kkx0r?

Originally Posted by brewbuck

bzero()? Let me guess, you're using some coding tutorial written by an El1t3 H4kkx0r?

yup

ok so i still don't get whats going on here

Code:

int main()
{
	char c;
	unsigned char filename[256];
	FILE *file;

	printf("Please enter the name of the file: ");
	fgets(filename,255,stdin);


	file = fopen(filename, "r");

	if(file == NULL){

		printf("Error: can't open file: %s.\n", filename);
		return 1;
	}
	else{
		printf("File opened successfully. Contents: \n\n ");

		while(1){
			c = fgetc(file);
			if(c!=EOF){
				printf("%c", c);
			}

			else{
				break;
			}
		}

		printf("\n\n Now closing file . . . \n");
		fclose(file);
		return 0;

	}
}

if i pass in "text.txt" into the command line (same folder) shouldn't it be able to open it?

No. The problem is that when you type in "text.txt", what actually goes into your buffer is "text.txt\n". A newline character is at the end of your filename string. You need to remove this newline character before you call fopen().

Check the value of int file.