Thread: segfaulting!

Im getting a segmentation fault when I try to run the program and add new message. As soon as I input the 3 values it segfaults. Any help?

Code:

#include <stdio.h>
#include <string.h>

struct MSG {
	int priority;
	int destination;
	char *message;
	int length;
	struct MSG *nextPtr;
};

typedef struct MSG Message;

int main ()
{
	struct MSG {
		int priority;
		int destination;
		char *message;
		int length;
		struct MSG *nextPtr;
	};

	struct MSG std[100];
	int I;
	int n;
	
	
	
	int choice = 0;


do
{
	printf("1.) Quit\n");
	printf("2.) Transmit next message\n");
	printf("3.) List messages by priority\n");
	printf("4.) Summarize message list\n");
	printf("5.) Add new message\n");
	printf(":");
	scanf("%d", &choice);
	switch(choice)
	{
		case 1:
			return 0;
		case 2:
			//transmit next message
			break;
		case 3:
			//list messages by priority
			break;
		case 4:
			//summarize message list
			break;
		case 5:
			//add new message
		        printf("How many messages would you like to enter?\n");
			scanf("%d", &n);
			printf("Enter a priority, destination, and message:");
			for (I=0; I < n; I++)
			{
				scanf("%d%d%s", &std[I].priority, &std[I].destination, &std[I].message);
			}
			printf("\ntest info:");
			for (I=0; I < n; I++)
			{
				printf("%d%d%s\n", std[I].priority, std[I].destination, std[I].message);
			}
			break;
		default:
			printf("Invalid entry, please try again.\n");
			break;
	}
}while (choice <= 5);

	return 0;
}

Your program is essentially doing this:

Code:

char *s;
scanf("%s", &s);

There are two problems there. First: you're trying to write to a location that has no memory allocated. s points nowhere (or rather, its value is indeterminate, but that's not important). You have to allocate space. You can either make s an array (which allocates the chars for you), or use malloc() to set aside some memory.

Second, you're passing &s, which has type "pointer to pointer to char", but %s expects "pointer to char". Though you've been conditioned to use & with scanf(), it's not for use with strings. Instead:

Code:

/* Either of these allocates space */
char *s = malloc(1024); /* should make sure s is not NULL now */
char a[1024];
/* Both of these are now correct */
scanf("%s", s);
scanf("%s", a);

scanf() isn't safe being used like this, but I presume you'd rather learn about that at a later date. scanf() is actually a pain to use properly for most applications.

Thanks for the help guys, I have this code now which freezes after I input the values:

Code:

#include <stdio.h>
#include <string.h>


int main ()
{
	struct MSG {
		int priority;
		int destination;
		char *message;
		int length;
		struct MSG *nextPtr;
	};

	struct MSG std[100];
        char message[100];
	int I;
	int n;
	
	
	
	int choice = 0;


do
{
	printf("1.) Quit\n");
	printf("2.) Transmit next message\n");
	printf("3.) List messages by priority\n");
	printf("4.) Summarize message list\n");
	printf("5.) Add new message\n");
	printf(":");
	scanf("%d", &choice);
	switch(choice)
	{
		case 1:
			return 0;
		case 2:
			//transmit next message
			break;
		case 3:
			//list messages by priority
			break;
		case 4:
			//summarize message list
			break;
		case 5:
			//add new message
		        printf("How many messages would you like to enter?\n");
			scanf("%d", &n);
			printf("Enter a priority, destination, and message:");
			for (I=0; I < n; I++)
			{
				scanf("%d%d%s", &std[I].priority, &std[I].destination, &std[I].message);
			}
			printf("\ntest info:");
			for (I=0; I < n; I++)
			{
				printf("%d%d%s\n", std[I].priority, std[I].destination, std[I].message);
			}
			break;
		default:
			printf("Invalid entry, please try again.\n");
			break;
	}
}while (choice <= 5);

	return 0;
}

Originally Posted by cas

scanf() isn't safe being used like this, but I presume you'd rather learn about that at a later date. scanf() is actually a pain to use properly for most applications.

Im here to learn so if you have better alternatives id love to hear them

Originally Posted by CMakesMeSad :(

Thanks for the help guys, I have this code now which freezes after I input the values:

Code:

#include <stdio.h>
#include <string.h>


int main ()
{
	struct MSG {
		int priority;
		int destination;
		char *message;
		int length;
		struct MSG *nextPtr;
	};

	struct MSG std[100];
        char message[100];
	int I;
	int n;
	
	
	
	int choice = 0;


do
{
	printf("1.) Quit\n");
	printf("2.) Transmit next message\n");
	printf("3.) List messages by priority\n");
	printf("4.) Summarize message list\n");
	printf("5.) Add new message\n");
	printf(":");
	scanf("%d", &choice);
	switch(choice)
	{
		case 1:
			return 0;
		case 2:
			//transmit next message
			break;
		case 3:
			//list messages by priority
			break;
		case 4:
			//summarize message list
			break;
		case 5:
			//add new message
		        printf("How many messages would you like to enter?\n");
			scanf("%d", &n);
			printf("Enter a priority, destination, and message:");
			for (I=0; I < n; I++)
			{
				scanf("%d%d%s", &std[I].priority, &std[I].destination, &std[I].message);
			}
			printf("\ntest info:");
			for (I=0; I < n; I++)
			{
				printf("%d%d%s\n", std[I].priority, std[I].destination, std[I].message);
			}
			break;
		default:
			printf("Invalid entry, please try again.\n");
			break;
	}
}while (choice <= 5);

	return 0;
}

I and i are not the same thing, although when I quote the code it magically has fixed itself.

What do you do to cause the error, and how far do you get?

Originally Posted by tabstop

I and i are not the same thing, although when I quote the code it magically has fixed itself.

What do you do to cause the error, and how far do you get?

I noticed that, in my code they're both "I" but when I post it hear they convert to "i"s for some reason. I get to the point where I add a new message, tell it how many messages I want to add, then as soon as I hit enter after inputing the first message it freezes.

Originally Posted by CMakesMeSad :(

I noticed that, in my code they're both "I" but when I post it hear they convert to "i"s for some reason. I get to the point where I add a new message, tell it how many messages I want to add, then as soon as I hit enter after inputing the first message it freezes.

That's not frozen. You said you wanted to input <n> messages; you've got to type <n> messages.

Originally Posted by tabstop

That's not frozen. You said you wanted to input <n> messages; you've got to type <n> messages.

I removed everything and just put this:

Code:

printf("Enter priority:\n");
scanf("%d", &std[I].priority);

I still get a segmentation fault as soon as I enter a number

Originally Posted by ಠ_ಠ

fgets

Thanks, Ill definitely look into it!