james457

Hi all,

I am sending data from a linux application through serial port to an embedded device.

In the current implementation a byte circular buffer is used in the firmware. (Nothing but an array with a read and write pointer)
As the bytes come in, it is written to the circular bufffer.

Now the PC application appears to be sending the data too fast for the firmware to handle. Bytes are missed resulting in the firmware returning WRONG_INPUT too mant times.

I think baud rate (115200) is not the issue. A more efficient data structure at the firmware side might help. Any suggestions on choice of data structure?

Thanks

Salem

<help withdrawn due to abuse from OP>

__________________
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.

itCbitC

Implement flow control either in hardware using the CTS/RTS signals (as noted) or in software using the XON/XOFF characters. Check if the embedded device supports hardware flow control as it isn't supported by all devices / OSes.

matsp

If you are sending data in bursts, you may also consider a larger circular buffer.

Also bear in mind that circular buffers where you use "pos = (pos + 1) % SIZE", if you pick a size that is 2 ^ n, you can use "pos = (pos + 1) & (SIZE-1)", which will be a much faster operation than the divide that the compiler MAY decide to generate for the % operator. The other option is to use an if-statement to modify the position. Also highly likely to be faster than the modulo operator (%). Since this is done twice for every character received, it may help to improve the peroformance.

The other aspect is of course what you are doing to extract from the circular buffer - for example, are you allocating memory when extracting? Are you doing some lengthy work to calculate something, or search for something with the received data - does that prevent incoming data from being accepted. Could you change that?

--
Mats

__________________
Compilers can produce warnings - make the compiler programmers happy: Use them!
Please don't PM me for help - and no, I don't do help over instant messengers.

james457

In the interrupt routine(background) data is written to the circular buffer. In the foreground I do process the received data right in the circular buffer using a state machine. Data is only copied over if the received data is in the correct format. The modulus is agood point, I will change that. Thanks