almost there.... please help

How do I incorporate an if/then into this to print a warning messege when a specified value is reached on the potentiometer.

int ReadPot()
{

int i;

pin = output; pin = l;
for (i = 0; i < charge; i++);
pin = input;
for ( i = 0; pin == l; i++);

return I ;

}

You should be waterboarded for not properly using code tags.

Quote:

---

Originally Posted by TommyBoy

How do I incorporate an if/then into this to print a warning messege when a specified value is reached on the potentiometer.

Code:

---

int ReadPot()
{

int i;
       
        pin = output; pin = l;
        for (i = 0; i < charge; i++);
        pin = input;
        for ( i = 0; pin == l; i++);

        return I ;

}

---

---

Sorry, that won't compile. You have declared i, but not I, and you have set pin equal to 'l', having never declared it as a variable.

Please post up the code that you're actually using - we can't give you good advice with this example.

Code:

---

if(vcPot == warningValue)
  ( print your warning message here);

---

That's pretty lousy, but it's the best I can do with your example code.

does this look any better?


function ReadPot()
{
int i;
i = output;
for(i;i<=charge;i++){

if(i>=1290){
printf("WARNING: MAX VALUE EXCEEDED\n");
return 0;
}
}
return 0;
}

Quote:

---

Originally Posted by MacGyver

You should be waterboarded for not properly using code tags.

---

Perhaps you think this is an idle threat.

http://cboard.cprogramming.com/c-pro...ead-first.html

You can combine

Code:

---

int i;
i = output;

---

into "int i = output;". Where is "charge" defined/declared?

ps. next time hold your breath

Code:

---

function ReadPot() {
  int i;
  i = output;
  for(i;i<=charge;i++){

    if(i>=1290){
      printf("WARNING: MAX VALUE EXCEEDED\n");
      return 0;
    }
  }
  return 0;
}

---

Yes, that does look better - but without knowing all the details of the rest of your code or what problem you're trying to solve - we can't say much more than that. Does it work for you?

Code tag box wasn't there, thanks for your concern Ace.

Quote:

---

Originally Posted by TommyBoy

Code tag box wasn't there, thanks for your concern Ace.

---

Hey Mr. Attentive! I did edit my post to include some useful info, I think. I didn't expect you to be so fast.

Isn't the potentiometer the main ingredient of the WAH_WAH pedal?

ps. you are suppose to add the code tag box dufus. It's not hard. Get used to it.

Thanks for your help MK...

You might wanna return something other than 0 when max value is exceeded to differentiate a normal return from an abnormal one.

Code:

---

  int i;
  i = output;
  for(i;i<=charge;i++){

---

Following up on what MK27 said, you can actually combine this all into one line:

Code:

---

for(int i=output;i<charge;i++) {

---

Quote:

---

Originally Posted by sean

Code:

---

for(int i=output;i<charge;i++) {

---

---

That is contra C99.

Oh riiight... yes - my bad.