beginner array help

Hi all. I am trying to find a way to read a file which has 10 lines and 4 columns of numbers and assign it to my arrays. The file itself is opening ok but for some reason it only reads the last line.

Code:

---

#include<stdio.h>
#include<ctype.h>
#include<stdlib.h>

int main( void )
{

        int number[10] = {0};
        int value1[10] = {0};
        int value2[10] = {0};
        int value3[10] = {0};


        FILE* readThis;
        if ((readThis = fopen ("file.txt", "r"
                )) ==NULL)  {
                        printf("\nError opening file \n");
                        exit(101);
        }

        while (!feof(readThis))  {
                fscanf( readThis, "%d %d %d %d", &number, &value1, &value2, &value3 );

        }
                fclose(readThis);

                printf("\n\n%d\n\n%d\n\n%d\n\n%d\n\n", number[0], value1[0], value2[0], value3[0]);//This prints the last line of the file
                printf("\n\n%d\n\n%d\n\n%d\n\n%d\n\n", number[1], value1[1], value2[1], value3[1]);//This prints all zeros



                return 0;
        }

---

any help would be appreciated thanks.

You need to iterate the data into your arrays:

&value1[i], etc., in your while loop

Just before the while loop, set i = 0, then last line in the while loop, increment i by 1.

You're going through the whole file, but you're overwriting all but the very last part of the data.

Pro-tip: use a 2 dimensional array (1x4).

Quote:

---

Originally Posted by abraham2119

use a 4 dimensional array.

---

I think that you are suggesting the use of an array of arrays of size 4, but I think that it would be better to use an array of struct objects.

Quote:

---

Originally Posted by laserlight

I think that you are suggesting the use of an array of arrays of size 4

---

Yes, my mistake.

Quote:

---

Originally Posted by Adak

You need to iterate the data into your arrays:

&value1[i], etc., in your while loop

Just before the while loop, set i = 0, then last line in the while loop, increment i by 1.

You're going through the whole file, but you're overwriting all but the very last part of the data.

---

thanks, it works perfect now.