Read until negative number

Hi,

I have a program to do
read numbers until negative number read

Code:

include <stdio.h>
void main ()

{

     int numbers  

     printf ("Type a number:")  

     scanf ("%d", &number)  

     if (number < 0)  // check whether the number is a negative number

     printf ("Value is %d \n", number) 

}

I wan to modify this program and wanted to print biggest and smallest number entered.
Say

if (ngative)
stop
print(biggest value)
print(smallest value)
end

anybody can help me
Thanks in advanced

What is missing is the logic. If you would read a number of numbers from a page until you find a negative number, how would you do?
You should also know about loops, if you do not know them already. They are present in the tutorials here.
And don't use void main - use int main.

please look at this.hope this is ok

Code:

include <stdio.h>
int main ()

{

     int numbers  

     printf ("Type a number:")  

     scanf ("%d", &number)  

     do
{
    printf ("Value is %d \n", number) 
} while (number < 0);


}

You might find "breaking out of a loop problem" thread helpfull.

Code:

include <stdio.h>
int main ()

{

     int numbers  

     printf ("Type a number:")  

     scanf ("%d", &number)  

    while(1)
   {
    scan... 
   if (number < 0)  // check whether the number is a negative number

     printf ("Value is %d \n", number) 

     }

     
}

hope now ok.so whats the next step to do?

Originally Posted by m_user

hope now ok

No, now you have an infinite loop. Your earlier do while loop was along the right lines, but you need to use the correct loop condition, i.e., you loop while the condition is true, not while the condition is false. I presume that you are also assuming correct (i.e., integer input within range) for now.

EDIT:
Actually, a while loop is probably the most appropriate here.

Originally Posted by laserlight

No, now you have an infinite loop. Your earlier do while loop was along the right lines, but you need to use the correct loop condition, i.e., you loop while the condition is true, not while the condition is false. I presume that you are also assuming correct (i.e., integer input within range) for now.

EDIT:
Actually, a while loop is probably the most appropriate here.

Sorry for asking this.cant get it.please show me a sample one

Originally Posted by m_user

Sorry for asking this.cant get it.please show me a sample one

I'll show you some pseudocode instead:

Code:

if scan into number and number is non-negative
    max_value = number
    min_value = number
    while scan into number and number is non-negative
        if number is greater than the current max_value
            max_value = number
        else if number is less than the current min_value
            min_value = number
    print max_value and min_value
else
    print message informing user that no non-negative numbers were entered

Hi what about this.I am not sure the while condition that i have used.Anything wrong correct the code

Code:

include <stdio.h>
int main ()

{

     int number,max_value,min_value;
     int valid = 0;


     printf ("Type a number:")  
     scanf ("%d", &number)  

	if(number > 0) //non-negative

		max_value=number
		min_value=number

			while(valid == 0)
				{
					if(number>max_value)
        				max_value=number
					else if(number<min_value)
					min_value=number
   					printf("The Max number is %d\n", max_value );
 					printf("The Min number is %d\n", min_value );
					else
					valid = 1;	
				}

	else

	printf("The number is non-negative number %d\n", number );

}

Originally Posted by m_user

I am not sure the while condition that i have used.

Yeah, your while loop is problematic because you never actually read the rest of the numbers entered. Also, from your description, you only want to print the max and min after the loop.

Originally Posted by m_user

Anything wrong correct the code

You are missing several terminating semi-colons and braces, and your code can be much better indented. Note that 0 is not negative.

the header file is
#include<stdio.h> not include<stdio.h>
also your code should return 0 at last.also you are inputting only one number,you should have a scanf inside the while loop for inputting several numbers.