Thread: Struct File and array problem Please help

Originally Posted by caroundw5h

you could make it even more compact

Code:

#define FLUSH while ( (getchar() ! = '\n') )

and then call FLUSH whenever you want to clean out the buffer.

And what will happen to this more compact code when stdin will be redirected to read from file and actually hits the EOF?

Getting code shorter by adding more bugs is not a good way to program

Originally Posted by vart

And what will happen to this more compact code when stdin will be redirected to read from file and actually hits the EOF?

where in his code is he redirecting stdin to read from a file (unless you mean waiting for the EOF to to be hit via the terminal)? His objective was to get the junk out of the input buffer and clean it up. To that end he can read up to the '\n' after each input. Sure he could add the EOF to that as well to that macro, just seems like overkill IMHO.

Getting code shorter by adding more bugs is not a good way to program

I agree whole heartedly, the objective on my part wasn't to offer a quick fix and forget potential future issues, it was to generate compact code for the task at hand. Why declare a long, when a int with do?

Originally Posted by caroundw5h

where in his code is he redirecting stdin to read from a file (unless you mean waiting for the EOF to to be hit via the terminal)?

The redirection can happen from the terminal/console/command prompt, not just the code.

Originally Posted by caroundw5h

His objective was to get the junk out of the input buffer and clean it up. To that end he can read up to the '\n' after each input. Sure he could add the EOF to that as well to that macro, just seems like overkill IMHO.

vart's point is about correctness. It might be a little paranoid, but the "overkill" will have no impact on performance anyway, and remains readable.