Largest Number

[lukesowersby]

Hi,

I'm required to write a program that prints the highest valued integer, from 3 entered values. Here is what i've got so far:

/* Week 5 Task*/
/* By Luke Sowersby */

#include <stdio.h>
#include <conio.h>
#include <string.h>

int i1, i2, i3;

int highest(int i1, int i2, int i3)
{
    int high;

    if(i1>i2>i3)
    printf("%d",i1);

    if(i1>i3>i2)
    printf("%d",i1);

    if(i2>i1>i3)
    printf("%d",i2);

    if(i2>i3>i1)
    printf("%d",i2);

    if(i3>i2>i1)
    printf("%d",i3);

    if(i3>i1>i2)
    printf("%d",i3);

    return high;
}

int main(void)
{

printf("Enter number 1: ");
scanf("%d",&i1);
printf("Enter number 2: ");
scanf("%d",&i2);
printf("Enter number 3: ");
scanf("%d",&i3);

int highest(int i1, int i2, int i3);

printf("Order: %d",highest(i1, i2, i3));

}

When printing the final result, it prints a 7 digit number.

Any help please?

[Maz]

In function highest, where do you set the largest number in retuned (high) variable?

Also, why do you have the declaration of highest inside main function?

You should also check the return value from scanf(), it may be the user decides to give your program something else than numeric values, and it is generally thought to be bad practice to allow such things to go unnoticed...

[cas]

The > operator does not do exactly what you think it does.

x > y > z is parsed as (x > y) > z. The > operator yields either a 1 or a 0, meaning true or false; this 1 or 0 is then compared to z.

In order to do the test, you'd want to say "if x is greater than y AND y is greater than z" (I assume this is what you want). So:

if(x > y && y > z)

[Snafuist]

The > operator appears 12 times throughout your code, although you need it only 2 times. Think about how you would compare three numbers in real life: you'd probably take two, compare them, and then compare the result with the third.

Greets,
Philip