Thread: Urgent!! Need help

Hi guys, I'm writing a program that works like a phone book
Im having a lot of problems dealing with the fgets() function
Everything works fine except the readSaved() function, the program always crashs on me when it reaches the fgets() function and I have no idea how to fix that, any suggestions?

Code:

int readSaved(struct Contact contact[])
{
	FILE *fp;
	int max = 2*NAMELENGTH + 2*PHONELENGTH;
	char *line,  *token;
	int i = 0;

	if((fp = fopen(FILENAME, "r")) != NULL)
	{
		fgets(line, max, fp);
		//printf("Readed first line\n");
		while((int)line != EOF)
		{
			//printf("Into loop\n");
			//printf("%s\n", line);
			token = strtok(line, " ");
			contact[i].first= token;

			token = strtok(NULL, " ");
			contact[i].last = token;
			
			token = strtok(NULL, " ");
			contact[i].home = token;
			
			token = strtok(NULL, "\n");
			contact[i].cell = token;

			i++;
			fgets(line, max, fp);
		}
		fclose(fp);
	}

	return i;
}

your line is not initialized pointer

Code:

char line[BUF_SIZE];
while(fgets(line , sizeof line, fp))
{
   /* process line */
}

FWIW,

From The Forum Guidelines

Tips for Efficient and Successful Posting

1. Don't use all caps.

2. Use descriptive subject lines. Do not put URGENT!, or NEED HELP NOW, etc. in your title; it will not make people look at it any faster. Doing this makes many old time helpers on this board not look at the post at all.

Again, the same thing is covered off in the excellent read How to ask questions the smart way.

To quote:

Don't flag your question as “Urgent”, even if it is for you

That's your problem, not ours. Claiming urgency is very likely to be counter-productive: most hackers will simply delete such messages as rude and selfish attempts to elicit immediate and special attention.

Anyhow.

As vart points out, line is simply a pointer, nothing else. It points to a random place in memory. Either use malloc() to allocate a segment of memory, or simply replace it with char line[BUFSIZ];. Use of BUFSIZ is optional, just use some value that you think is large enough to store the content of one line; perhaps that nice little handy max variable you have there. (Once you make max const, of course.)

Perhaps passing a string to readSaved() that is the filename would also help with flexibility later on, if you need to expand on this program, so that it can read from different "books".