Need help with "if" function

[wipeout4wh]

I just started coding in C today, and I haven't been able to figure out what is wrong with this. I am trying to make a "guess the number" game, but I keep getting a syntax error on the "if" line. Could someone please tell me what is wrong with this?

#include <stdio.h>


int main()
{
    int correct;
    correct=13;
{
  int number;
  printf ( "Guess a number: ");
  scanf( "%d", &number );
  return 0;
}
}
if(correct==number)
{
                   printf("You Win!"
                   }
else
{
    printf("You Lose")
}

[sean]

You don't need your second, third or forth curly braces, but you should have one after the else statement.

return 0; should only be at the end of your program - execution will end when it gets to this point.

There's nothing wrong with the if statement itself.

You need closing parentheses and semi colon after "You Win!"

[wipeout4wh]

After the else statement?

else
{
    printf("You Lose")
}

Why would I need another one? It already has a beginning and end bracket...

Edit: oh, I see what you mean.

[wipeout4wh]

Ok, I got it working, but could you tell me how to make the number random every time instead of a constant?

[sean]

http://www.cprogramming.com/tutorial/random.html

The code in that tutorial is C++, so it's a slightly different syntax in some parts, but the random number part should be the same for C.

i.e. You "seed" it by passing srand some value based on the time, then subsequent calls to rand() return random numbers. Include stdlib.h to use those functions and the RAND_MAX constant.

[Nightowl]

By using the srand() and rand() functions contained in stdlib.h.

srand() seeds the random number generator with a value. If given the same seed, then rand() will return the same numbers in sequence. Usually, the time is used to seed the random number generator. So, for example:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

int main(int argc, char *argv[]) {
    srand(time(NULL));
    printf("A random number: %i\n", rand());
    printf("A random number between 0 and 99: %i\n", rand()%100);
    return 0;
}

Stepping through that, well.

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

I think you probably know what these are. In this case, stdio.h is used for printf(), stdlib.h for srand() and rand(), time.h for time().

int main(int argc, char *argv[]) {

Standard main() function.

    srand(time(NULL));

This calls srand() with the current time, as returned by the time() function. If you pass a pointer to time(), it will store the time in that variable. But because it additionally returns the time, you can seed the random number generator directly without using an additional variable.

    printf("A random number: %i\n", rand());
    printf("A random number between 0 and 99: %i\n", rand()%100);

The first simply prints out a randomly-generated number from the rand() function. This will be between 0 and (2^31)-1, probably not what you want. So, the second applies a modulus of 100 to the randomly-generated value. Modulus = remainder. Think of it as converting 1234 into 34, removing all but the tens and ones columns of a number. (If you use number%2, it will be 1 if number is odd, 0 if it's even.)

    return 0;
}

Terminate with a return code of 0, or success.

EDIT: dang, sean beat me to it :P

[wipeout4wh]

Edit: nvm, I got it. Thanks for your help.

[wipeout4wh]

Ok, I need help again

Now I am trying to make it so you can choose to try again after you win or lose. I looked in the other thread that was similar, but I can't figure it out. What is wrong with this?:

#include <stdio.h>
#include <conio.h>
#include <ctype.h>
#include <process.h>


int main(int argc, char *argv[])
{
    int guess;
    char choice, y, n, Y, N;
    Y=y;
    N=n;
    
while (choice == y)
{
    printf("Guess a number: ");
    scanf("%i" , &guess);
    srand(time(NULL));
    if(guess==rand()%21)
    printf("\nYou Win!");
    else
    printf("You Lose! My number was: %i" , rand()%21);
                 char choice;
         printf("\nWould you like to try again? [Y/N]: \n");
         scanf( "%c" , &choice );
}
}

[vart]

have you already searched the forum?

[wipeout4wh]

I found a thread about it, but I still can't figure it out.

[vart]

char choice = 'n';
do
{
   ...
   scanf("%c ",&choice);
} while(tolower(choice) == 'y');

[Nightowl]

    
while (choice == y)

Should that not be (choice == 'y')?

[Nightowl]

An example program, much like what I think you're trying to do . . .

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>

int main(int argc, char *argv[]) {
    int i, num, tries;
    char cont;
    srand(time(NULL));
    
    do {
        num = (rand()%100)+1;
        i = -1;
        tries = 0;
        while(num != i) {
            if(i != -1) {
                if(i > num) {
                    printf("Too high!\n");
                }
                else printf("Too low!\n");
            }
            printf("Enter a number between 1 and 100: ");
            scanf("%i", &i);
            tries ++;
        }
        printf("Got it in %i %s. Again? [yY/nN] ", tries, tries == 1?"try":"tries");
        while((cont = tolower(getchar())) && cont != 'y' && cont != 'n') ;
    } while(cont == 'y');
    
    return 0;
}

Example output:

Enter a number between 1 and 100: 1
Too low!
Enter a number between 1 and 100: 50
Too low!
Enter a number between 1 and 100: 75
Too high!
Enter a number between 1 and 100: 66
Too high!
Enter a number between 1 and 100: 59
Too high!
Enter a number between 1 and 100: 55
Too low!
Enter a number between 1 and 100: 57
Too high!
Enter a number between 1 and 100: 56
Got it in 8 tries. Again? [yY/nN]y
Enter a number between 1 and 100: 50
Too low!
Enter a number between 1 and 100: 75
Too low!
Enter a number between 1 and 100: 88
Too high!
Enter a number between 1 and 100: 81
Too low!
Enter a number between 1 and 100: 84
Too low!
Enter a number between 1 and 100: 86
Too low!
Enter a number between 1 and 100: 87
Got it in 7 tries. Again? [yY/nN]n

[Elysia]

Ok, I need help again

Now I am trying to make it so you can choose to try again after you win or lose. I looked in the other thread that was similar, but I can't figure it out. What is wrong with this?:

Any characters, such as y needs to be enclosed in single quotes, thus: 'y'.
If you do NOT do this, the compiler thinks it's a variable and it's not, is it?

Furthermore, srand should only be called once during your program.
And you'll want to cast the return of time to avoid compiler warnings:

srand( (unsigned int)time(NULL) );

And lastly, you need to look into what indentation is: http://cpwiki.sourceforge.net/Indentation

[wipeout4wh]

An example program, much like what I think you're trying to do . . .

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>

int main(int argc, char *argv[]) {
    int i, num, tries;
    char cont;
    srand(time(NULL));
    
    do {
        num = (rand()%100)+1;
        i = -1;
        tries = 0;
        while(num != i) {
            if(i != -1) {
                if(i > num) {
                    printf("Too high!\n");
                }
                else printf("Too low!\n");
            }
            printf("Enter a number between 1 and 100: ");
            scanf("%i", &i);
            tries ++;
        }
        printf("Got it in %i %s. Again? [yY/nN] ", tries, tries == 1?"try":"tries");
        while((cont = tolower(getchar())) && cont != 'y' && cont != 'n') ;
    } while(cont == 'y');
    
    return 0;
}

Ok, thank you. Could you explain this code to me though? Also how would I make it so you don't need to press enter after pressing y or n? If that is too complicated, don't worry about it, since I'm not very good at this yet and probably wouldn't understand.