Thread: Function help?

If you are just comparing a single character, you should do it this way:

Code:

if (temp[i]=='a')

Notice single quotes!

Actually, in this case you probably want to use case:

Code:

switch (temp[i]) {
        case 'a':  strcat(temp2,"0");  break;
        case 'b':  strcat(temp2,"1");  break;

Altho there is an even easier way, because ASCII characters have numerical values (a is 97, b is 98, etc, and 0 is 48, 1 is 49), so you could just go:

Code:

for (i=0; i<strlen(temp); i++) temp2[i]=temp[i]-97+48;
temp2[i]='\0';  /* now null terminate temp2 */

Which is the whole thing in two lines.

One more note: don't use strcat() on an uninitialized string, because it will not be null terminated. Initialize it the string this way first:

Code:

char temp2[20]="\0";

While on the topic of exploits and optimization, you are better to NOT use strlen in a for loop unless the length of the string is actually changing, since this means performing a strlen() at each iteration, witness

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main() {
	char string[]="string is this", two[]="string", *ptr=string;
	int i;
	for (i=0;i<strlen(ptr);i++) {
		printf("%c%d",ptr[i],i);
		ptr=two;
	}
}

So in the context of that two lines from the other post, three lines is more optimal:

Code:

int len=strlen(temp);
for (i=0; i<len; i++) temp2[i]=temp[i]-97+48;
temp2[i]='\0';  /* now null terminate temp2 */

The problem is that temp is an array of chars. An array will decay to a pointer to its first element when passed to a function, but since you use the index operator, you get a char from that array and char != char*.
So there you have it.

Originally Posted by Elysia

The problem is that temp is an array of chars. An array will decay to a pointer to its first element when passed to a function, but since you use the index operator, you get a char from that array and char != char*.
So there you have it.

meaning while "temp" is a valid pointer for strcmp, temp[i] is not (hence the warning about it being an integer, which it more or less is, a=97, b=98...)

temp+i would work.

And so would &temp[i].
Note that this would give the string starting off from the position i, and not a single character.

Yes, it is, but you don't need to get worked up about it.
I was explaining the technical reason behind why strcmp doesn't work and I suppose MK27 just added what might work with strcmp, but what not be the right case here.

Originally Posted by Elysia

Yes, it is, but you don't need to get worked up about it.
I was explaining the technical reason behind why strcmp doesn't work and I suppose MK27 just added what might work with strcmp, but what not be the right case here.

Indeed, and I would be much more likely (in fact almost certain) to use &temp[i] if my brain was typing code at the time. Hmmm.