Thread: Argv to string?

well, I wanted to make the array I create more malleable, so I could run though it simply than using argv or something.
I'm not all that good at pointers...Does this work? It compiles okay..

Code:

#include <stdio.h>
#include <stdlib.h>

#define STR_LENGTH 50

int main(int argc, char *argv[]) 
{
	char phraseOne[STR_LENGTH], phraseTwo[STR_LENGTH];

		int i = 0, k = 0, counter1 = 0, counter2 = 0;

	while(argv[1][i]!='\0')
	{
 		phraseOne[i] = argv[1][i]; // Copy the content of the second array
		i++;
		counter1++;
	}
	
	while(argv[2][k]!='\0')
	{
 		phraseTwo[k] = argv[2][k]; // Copy the content of the second array
		k++;
		counter2++;
	}

	return 0;
}

EDIT: changed for loops...made it stop when the main string is null..

Originally Posted by azrael

well, I wanted to make the array I create more malleable, so I could run though it simply than using argv or something.

What do you mean by "more malleable"?

Originally Posted by azrael

Does this work?

Only in special cases. You need to copy the characters from argv[1] and argv[2] until and including the null character. You may find it handy to use strncpy() instead of coding your own loop, but you would need to insert the null character yourself to account for the cases where the number of characters in argv[1] and argv[2] is not less than STR_LENGTH.

Sorry for the delay, my network connection seems to be fluctuating.

Originally Posted by azrael

I just didn't want to be fumbling with the argv thing...Seemed easier to copy it to its own string.

If you do not want to write argv[1] and argv[2], then just use pointers:

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[])
{
    if (argc > 2)
    {
        char *phraseOne = argv[1];
        char *phraseTwo = argv[2];

        printf("%s %s\n", phraseOne, phraseTwo);
        /* ... */
    }

    return 0;
}

Note that you can use array notation with pointers.

Originally Posted by azrael

I just changed the loops to work until its null. Is that better?

If you really want to copy over you need to loop until either the current character is null, or the maximum length of the destination string has been reached. Frankly, don't bother copying, and instead concentrate on your actual task. If you write a function to complete your task, writing argv[1] and argv[2] is hardly going to be confusing since the bulk of the work with the strings would be done with the function where the parameters are appropriately named.