Thread: Strange problem in my new program, dealing with variables.

Hey, so I've been writing this new program to help me run aircrack-ng a little faster. Here is what I have thus far.

Code:

#include <stdio.h>
int main()
{
 char bssid[20];
 char essid[20];
 int channel;
 printf("AP BSSID:");
 fgets(bssid,20,stdin);
 printf("AP ESSID:");
 fgets(essid,20,stdin);
 printf("AP CHANNEL:");
 scanf("%d",&channel);
 printf("sudo airodump-ng -c %d -d %s -w %s mon0",&channel,bssid,essid);
 printf("sudo aireplay-ng -1 0 -e '%s' -a %s -h 00:19:7E:71:C0:2D mon0",essid,bssid);
 printf("sudo aireplay-ng -3 -b %s -h 00:19:7E:71:C0:2D mon0",bssid);
 printf("sudo aircrack-ng -z -b %s %s*.cap",bssid,essid);
 getchar();
 return 0;
}

Here is what I get when I input 00:11:22:33:44:55 for the BSSID FakeNet for the ESSID and 6 for the CHANNEL.

Code:

beatzz@hax0r:~$ ~/documents/c/./cracKrocKs
AP BSSID:00:11:22:33:44:55
AP ESSID:FakeNet
AP CHANNEL:6
sudo airodump-ng -c -1082094220 -d 00:11:22:33:44:55
 -w FakeNet
 mon0sudo aireplay-ng -1 0 -e 'FakeNet
' -a 00:11:22:33:44:55
 -h 00:19:7E:71:C0:2D mon0sudo aireplay-ng -3 -b 00:11:22:33:44:55
 -h 00:19:7E:71:C0:2D mon0sudo aircrack-ng -z -b 00:11:22:33:44:55
 FakeNet
*.capbeatzz@hax0r:~$

as you can see it dose not put each line of code on a line by itself, its all jumbled, and if u noticed, my channel number is ridiculously NOT what I assigned it. Any advice?

P.S. Comment for the admins, I run aircrack-ng on my own home network, for security purposes

fgets also reads the newlines (\n), so you may want to strip them...
Also, when using %d, print does not expect the address of the argument to print, so don't pass a pointer - pass by value.

You do, since fgets reads those (they're in the input buffer).
It's the last character (before the \0 in the buffer).
buf[ strlen(buf) - 1 ] = '\0';
Should get rid of those.