Finding Character In String

[Air]

I have to allow a user to input a character. The user then inputs a string and the function is to count the amount of time the character appears in the string. I have produced a user-defined function which points to the main function. However, it's not complier is giving coding error in the 'if' function part. Can someone help with the correction. Thanks in advance.

#include <stdio.h>
#include <string.h>

int strFind(char ch, char *str)
{     
      
   int i, n=0;

   for(i=0; i<strlen(str); i++){
              if(str == ch){
                     n++;} 
              else{
                     }
            }
            
 }



int main()
{
    char ch, str[100];
    
    printf("Please enter a single character: ");
    scanf("%c", &ch);
    
    printf("Please enter a string: ");
    scanf("%s", &str);
    
    strFind(ch, *str);
    printf("The number of '%c' in '%s' is %d", ch, str, n);
    
    scanf("%d");
    return 0;
    
}

[tabstop]

You can't compare a pointer to a character with a character. Presumably you want to compare the character pointed to by str with the character ch.

[Air]

You can't compare a pointer to a character with a character. Presumably you want to compare the character pointed to by str with the character ch.

Yes, so it should be: str* == ch ?

[matsp]

*str == ch, more like.

--
Mats

[MacNilly]

It should be *str to deference the character itself.

Also, I don't believe you need to use this syntax: *str or &str in the main function. The array name itself IS a pointer, so you can just say scanf("%s", str).

[Air]

Thanks.

Theres another error which says that 'n' is undefined in the 'int main()'. How can I bring it from the user defined function?

[MacNilly]

Looks like you need to return n from your function.

You could do it at least two ways:

declare n in main, then pass n as a reference parameter (int *) to your function.

or

declare n in main, then assign n the value of your function when it returns a value. In this case, inside your function you need to declare n before using it, like you are doing right now (in both main and your function)