Thread: Function

This program reads an integer n of M digits (defined at the beginning) and a one-digit integer d; if d is in n it has to print n and and the sum (+) symbol below every occurance of d.
It compiles, and works fine in the case M=1,2 and 3, but it starts doing funny things when M=4 and up...

Any advice is appreciated.
Thanks!

Code:

#include <stdio.h>
#include <stdlib.h>
#include <math.h>
#define M 4

int procesar(int n, int d);

int procesar(int n, int d)
{
int esta=0;
int i,aux;

for(i=0;i<M;i++)
    {
    aux=n/pow(10,M-(i+1));
    if(aux==d)
        {
        esta=1;
        printf("+");
        }
    else
        printf(" ");
    n=n-(aux*pow(10,M-(i+1)));    
    }
return esta;
}

int main()
{
int n,d;

scanf("%d %d",&n,&d);  
printf("%d\n",procesar(n,d));

  system("PAUSE");	
  return 0;
}

Originally Posted by vart

you do not need pow to extrct digits from number
enough % and /

Ok, but it should work too that way.

In the case M=4, this is what happens:

Code:

1234 4
    0

or

Code:

1244 4
  + 1

I´m aware that the "0" and "1" that appears is the return that is in the program (which by the way I don´t know how to get rid of...) but the last 4 shold have a "+" below...

Surely we've figured out what printf is by now.... If you don't want something to print, don't printf it.

And your example is incorrect: input of 1234 4 gives

Code:

1234 4
   +1

which is what you wanted, so I'm not sure what your problem is.

Originally Posted by matsp

Actually, I can reproduce the exact results of the original poster - however, I think it may well depend on the compiler & settings. gcc-mingw (3.4.x) that is distributed with dev-cpp seems to reproduce the problem, as stated above - that is, with no extra options - adding -O3, and it "works", but -O1 -ffast-math doesn't, for example.

--
Mats

Hey, you're right. (I have -O3 set in my IDE, which is why it didn't occur to me to go without. Take it away and bad things happen.)

matsp:


Could you give me an example of how it should be with % and /??

So, it is wrong or what?? Now I´m getting confused....