Need help with liquid measurements using functions and remainders.

[deleted_user]

Can someone please tell me what is wrong with this program? it is supposed to output 1 gallon, 2 quarts, 1 pint, and 1 cup. The math isn't right on the gallons, It is displaying some strange decimal that seems to go on forever. It also isn't printing anything for quarts, pints, and cups. Help!

#include <stdio.h>
  void liquid(float*, float*, float*, float*);

  int main()
  {
      int remainder, input;
      float gallons, quarts, pints, cups;
      
      printf("How many cups do you have?:  \n");
      scanf("%f",&input);
    
	  gallons = input/16;
	  remainder = input % 16;
      quarts = remainder/4;
	  remainder = remainder % 4;
      pints = remainder/2;
	  remainder = remainder % 2;
      cups = remainder;
      
     liquid(&gallons, &quarts, &pints, &cups);
      return 0;
   }
   void liquid(float *gallons, float *quarts, float *pints, float *cups)
     {  
        
   printf("You have %f gallon(s).\n",*gallons);
   printf("You have %f quart(s).\n",*quarts);
   printf("You have %f pint(s).\n",*pints);
   printf("You have %f cup(s).\n",*cups); 
    
    
      return;
    
}

[tabstop]

You can't use %f to read into an integer variable.

[deleted_user]

I tried using %d and it displayed nothing but zeros. Please help me fix this.

[c++0x]

#include <stdio.h>
  void liquid(float, float, float, float);

  int main(void)
  {
      int remainder, input;
      float gallons, quarts, pints, cups;
      
      printf("How many cups do you have?:  \n");
      scanf("&#37;d",&input);
    
	  gallons = (float)input/16.0f;
	  remainder = input % 16;
      quarts = (float)remainder/4.0f;
	  remainder = remainder % 4;
      pints = (float)remainder/2.0f;
	  remainder = remainder % 2;
      cups = remainder;
      
     liquid(&gallons, &quarts, &pints, &cups);
      return 0;
   }
   void liquid(float gallons, float quarts, float pints, float cups)
     {  
        
   printf("You have %f gallon(s).\n",gallons);
   printf("You have %f quart(s).\n",quarts);
   printf("You have %f pint(s).\n",pints);
   printf("You have %f cup(s).\n",cups); 
    
    
      return;
    }

[tabstop]

I tried using %d and it displayed nothing but zeros. Please help me fix this.

You have an interesting idea of what "all zeros" mean.

$ ./temp
How many cups do you have?:  
19
You have 1.000000 gallon(s).
You have 0.000000 quart(s).
You have 1.000000 pint(s).
You have 1.000000 cup(s).

(After changing to %d.)

[deleted_user]

You have an interesting idea of what "all zeros" mean.

$ ./temp
How many cups do you have?:  
19
You have 1.000000 gallon(s).
You have 0.000000 quart(s).
You have 1.000000 pint(s).
You have 1.000000 cup(s).

(After changing to %d.)

When I ran the program, my results were nothing but zeros. Are you telling me that when you ran the program and only changed the %f to %d that it worked?

[tabstop]

When I ran the program, my results were nothing but zeros. Are you telling me that when you ran the program and only changed the %f to %d that it worked?

That is correct. (Note that you only change the %d where the variable is an integer -- so just in the one place.)

[deleted_user]

So, I just change it for scanf("%d",&input); Right? That would explain why I go all zeroes. I changed it to %d in every instance. Oh, and how to I get it to display just the number 1 instead of 1.000000?

[c++0x]

#include <stdio.h>
void liquid(float, float, float, float);

int main(void)
{
   int remainder, input;
   float input, gallons, quarts, pints, cups;
      
   printf("How many cups do you have?:  \n");
   scanf("&#37;d",&input);
    
   gallons = (float)input/16.0f;
   remainder = input % 16;
   quarts = (float)remainder/4.0f;
   remainder = remainder % 4;
   pints = (float)remainder/2.0f;
   remainder = remainder % 2;
   cups = remainder;
      
   liquid(&gallons, &quarts, &pints, &cups);
   return 0;
}
void liquid(float gallons, float quarts, float pints, float cups)
{  
        
   printf("You have %.0f gallon(s).\n",gallons);
   printf("You have %.0f quart(s).\n",quarts);
   printf("You have %.0f pint(s).\n",pints);
   printf("You have %.0f cup(s).\n",cups); 
   return;
}

Wurks 2.

[tabstop]

So, I just change it for scanf("%d",&input); Right? That would explain why I go all zeroes. I changed it to %d in every instance. Oh, and how to I get it to display just the number 1 instead of 1.000000?

Set your precision to 0, a la %.0f. Or you could use the proper data type for the job, and change everything else to ints too.

[deleted_user]

Set your precision to 0, a la %.0f. Or you could use the proper data type for the job, and change everything else to ints too.

I don't understand what you mean by "Set your precision to 0, a la %.0f." Could you post an example using my code so that I can see what you mean? Also, I tried changing everything to int and the program wouldn't work at all. I just ended up with error messages. Are you saying that it should work if every float is changed to an int?

[c++0x]

I found a great example of this here. If you are interested.

[tabstop]

If every float is changed to an int (and of course you use %d everywhere) then it will work much better yes. And I don't know what you don't understand about "change %f to %.0f".