Thread: Help- While loop

What is wrong with it?
for some reason if I type a, A, s, S it still does the loop

Code:

while (Album != "a" || Album != "A" || Album !="s" || Album != "S")
    {
          printf("Sorry invalid character\n");
          printf("Is it a Album or a Single?\n (Type A for Album or S for Single): ");
          fflush(stdin);
          scanf("%c", &Album);
}

Originally Posted by zacs7

Anything in double quotes is a string literal (well, depending on context...) So you're comparing the (read-only) address of the string literal. Use single quotes if you mean a character.

Don't fflush(stdin), you've already been told it's very, very wrong before (http://cboard.cprogramming.com/showt...php?t=110167#4) -- see the FAQ.

I know its very very wrong to use fflush(stdin); but my guide telsl me to use it only for now so...

i tried doing what you told me but it still doesn't work here is my whole source code.

Code:

#include <stdio.h>
#include <stdlib.h>

main()
{   
    // My variebles
    char Title[31],Artist[31],Album;
    int NumberofTracks;
    float price;
    
    
    // Grabbing the variebles
    printf("Welcome to CD data saver!\n");
    printf("Please enter the CD details Below:\n");
    printf("Title? ");
    scanf("%[^\n]", &Title);
    printf("Artist? ");
    fflush(stdin);
    scanf("%[^\n]", &Artist);
    printf("Number of tracks? ");
    fflush(stdin);
    scanf("%d", &NumberofTracks);
    printf("Is it a Album or a Single?\n (Type A for Album or S for Single): ");
    fflush(stdin);
    scanf("%c", &Album);
    while (Album != 'a' || Album != 'A' || Album != 's' || Album != 's')
    {
          printf("Sorry invalid character\n");
          printf("Is it a Album or a Single?\n (Type A for Album or S for Single): ");
          fflush(stdin);
          scanf("%c", &Album);
}
    
    printf("Price? (e.g 9.98): ");
    fflush(stdin);
    scanf("%f", &price);
    
    // Results    
          printf("\n\nThe CD data you entered are:\n\n");
          printf("==========CD DATA==========\n");
          printf("Title: %s\n", Title);
          printf("Artist: %s\n", Artist);
          if ( Album == "a" || Album == "A")
          {
          printf("Album\n");
          }
          else
          {
          printf("Single\n");
          }
          printf("Number of tracks: %d\n", NumberofTracks);
          printf("Price $ %.2f\n", price);
          printf("==========CD DATA==========\n");
          printf("\nPress ENTER to exit program.");
    // End results
          
    fflush(stdin);
    getchar();
    
}

yeah thanks didn't notice that but I solved my problem my using && instead of || and it workd

lol well its the only video guide I got. It is probably outdated thats why.