Fucntion returns -1, Why?

This function that I have returns '-1' whenever it enters the last else can anyone tell me why so I can go about fixing it?? (Hope Indentation is correct)

Perhaps the fucntion wants to return something to main before it calls itself again and defaults to -1 ??? Or is the problem with scanf? Does it not like reading in a value for 'note' again when it already has one stored (previously in main)???

Code:

int convert(const char *note){ if( strcmp(note,"C") == 0 || strcmp( note, "c")==0 ||strcmp( note, "B#" ) == 0 || strcmp( note, "b#")==0) return 0; else if( strcmp( note, "C#" ) == 0 || strcmp( note, "c#")==0||strcmp( note, "Db" ) == 0 || strcmp( note, "db")==0 ) return 1; else if( strcmp( note, "D" ) == 0 || strcmp( note, "d")==0) return 2; else if( strcmp( note, "D#" ) == 0 || strcmp( note, "d#")==0||strcmp( note, "Eb" ) == 0 || strcmp( note, "eb")==0 ) return 3; else if( strcmp( note, "E" ) == 0 || strcmp( note, "e")==0||strcmp( note, "Fb" ) == 0 || strcmp( note, "fb")==0 ) return 4; else if( strcmp( note, "F" ) == 0 || strcmp( note, "f")==0||strcmp( note, "E#" ) == 0 || strcmp( note, "e#")==0 ) return 5; else if( strcmp( note, "F#" ) == 0 || strcmp( note, "f#")==0||strcmp( note, "Gb" ) == 0 || strcmp( note, "gb")==0 ) return 6; else if( strcmp( note, "G" ) == 0 || strcmp( note, "g")==0 ) return 7; else if( strcmp( note, "G#" ) == 0 || strcmp( note, "g#")==0||strcmp( note, "Ab" ) == 0 || strcmp( note, "ab")==0 ) return 8; else if( strcmp( note, "A" ) == 0 || strcmp( note, "a")==0 ) return 9; else if( strcmp( note, "A#" ) == 0 || strcmp( note, "a#")==0||strcmp( note, "Bb" ) == 0 || strcmp( note, "bb")==0 ) return 10; else if( strcmp( note, "B" ) == 0 || strcmp( note, "b")==0||strcmp( note, "Cb" ) == 0 || strcmp( note, "cb")==0 ) return 11; else { printf("Not a Vaild Entry!!!\n"); printf("Please enter note AGAIN:"); scanf("%s",note); convert(note); return 0; } }

More code please (like the caller). And bump up the warning level... you can't write to const objects,

Code:

scanf("%s",note);

note is const

Yes, it's not possible to say without looking at the function that calls convert() (main() perhaps).

Ok I deleted my last post because i just realised that 'return 0;' should not be in the last else its part of my debugging.

Even when I remove 'const' it still retruns -1

here is the rest of the code:

Code:

#include<stdio.h> int convert(char *note); int main(void){ char note[40][40]; \\static int array[12]; int dArray[12][12]; int i, j; for(i=0;i<12;i++) { printf("Please enter note %d in the series:",i+1); scanf("%s",note[i]); dArray[i][0]=convert(note[i]); } printf("\n\t"); for(i=0;i<=11;i++) { printf("%d\n\t",dArray[i][0]); } for(i=0;i<=10;i++) { dArray[0][i+1]=(((dArray[0][i]+(dArray[i][0]-dArray[i+1][0])+12)%12)); } for(i=1;i<=11;i++) { for(j=1;j<=11;j++) dArray[i][j]=(dArray[i][j-1] + (dArray[i-1][j]-dArray[i-1][j-1])+12)%12; } printf("\n***** Equivalent Serial Matrix *****\n"); for(j=0;j<12;j++) { printf("\n"); for(i=0; i<12; i++) printf("%d ",dArray[i][j]); } printf("\n"); } int convert(char *note){ if( strcmp(note,"C") == 0 || strcmp( note, "c")==0 ||strcmp( note, "B#" ) == 0 || strcmp( note, "b#")==0) return 0; else if( strcmp( note, "C#" ) == 0 || strcmp( note, "c#")==0||strcmp( note, "Db" ) == 0 || strcmp( note, "db")==0 ) return 1; else if( strcmp( note, "D" ) == 0 || strcmp( note, "d")==0) return 2; else if( strcmp( note, "D#" ) == 0 || strcmp( note, "d#")==0||strcmp( note, "Eb" ) == 0 || strcmp( note, "eb")==0 ) return 3; else if( strcmp( note, "E" ) == 0 || strcmp( note, "e")==0||strcmp( note, "Fb" ) == 0 || strcmp( note, "fb")==0 ) return 4; else if( strcmp( note, "F" ) == 0 || strcmp( note, "f")==0||strcmp( note, "E#" ) == 0 || strcmp( note, "e#")==0 ) return 5; else if( strcmp( note, "F#" ) == 0 || strcmp( note, "f#")==0||strcmp( note, "Gb" ) == 0 || strcmp( note, "gb")==0 ) return 6; else if( strcmp( note, "G" ) == 0 || strcmp( note, "g")==0 ) return 7; else if( strcmp( note, "G#" ) == 0 || strcmp( note, "g#")==0||strcmp( note, "Ab" ) == 0 || strcmp( note, "ab")==0 ) return 8; else if( strcmp( note, "A" ) == 0 || strcmp( note, "a")==0 ) return 9; else if( strcmp( note, "A#" ) == 0 || strcmp( note, "a#")==0||strcmp( note, "Bb" ) == 0 || strcmp( note, "bb")==0 ) return 10; else if( strcmp( note, "B" ) == 0 || strcmp( note, "b")==0||strcmp( note, "Cb" ) == 0 || strcmp( note, "cb")==0 ) return 11; else { printf("Not a Vaild Entry!!!\n"); printf("Please enter note AGAIN:"); scanf("%s",note); convert(note); } }

main() is not returning an explicit value. Surely you are getting compiler warnings that you are not addressing.

Code:

else { printf("Not a Vaild Entry!!!\n"); printf("Please enter note AGAIN:"); scanf("%s",note); return convert(note); } }

recursion tip

Well, it appears to work for me.

A few warnings:
implicit declaration of strcmp (you need to include <string.h>).

Control reaches end of both non-void functions. Main should return 0 and well... convert probably shouldn't recurse potentially infinitely.

I would suggest that you return the final else part and move it into main. It is not normally a task of functions to keep whining about bad input, that's what the caller should whine about.

There may be other things to do: converting tolower/toupper would halve the comparisons. Storing the notes/return values in some kind of array (of structs) would let you use a loop for the lookup.

No warnings at all ????????? I'm using gcc from the command line and notepad :-/ Can you explain what you just replied with sorry i'm a bit of a newbie to this C lark.

try

Code:

gcc -Wall -Wextra -pedantic -ansi asdf.c -o asdf

That should give you plenty of warnings.

Code:

else { printf("Not a Vaild Entry!!!\n"); printf("Please enter note AGAIN:"); scanf("%s",note); return convert(note); } }

This could also look like this:

Code:

else { printf("Not a Vaild Entry!!!\n"); printf("Please enter note AGAIN:"); scanf("%s",note); x=convert(note); return x; } // hmmm, no return after this else }

Don't worry, that's how it suppose to be. I think if you try -Wall gcc would have filled you in.

For all the trouble i went to in installing gcc it hasn't impressed me so far i should know about these warnings!!!

Question if i use Borland C++ will i be able to program in C normally and will it allow me to do things that I wouldn't normally be able to do in just a C compiler? Can i set it up only to allow me to program in C?

The 'return convert(note)' tip works but I think I will do what anon says and keep that else in main.

I will also need to prevent the user from entering the same note twice so an array of structs is a good idea.

Thank you.

EDIT:
So what exactly should i be typing if my program is named 'note'

'Wall - gcc -o note note.c' ?????????

Is there any simple compiler that I can install and use that doesn't involve me learing off lists of commands?? ie If i want to compiler i should click a button if i want to run i should click run????? Why is C still in the dark ages, all this gcc lark is what prevents people from getting stared easily. For insatnce there is BlueJ for java.

Taper! don't go crazy!

try:

gcc -Wall -Fix_my_code -awesome -o note note.c

The compiler comes first on the command line:

Code:

gcc -Wall -o note note.c

Butt, joke, me...

edit:
Thanks rags

Most people here use an IDE (such as Code::Blocks or even DevCpp - which is not very good but enough for single-file small programs etc), not Notepad - although it is useful to be able to compile from command prompt.

Don't they have a vim for windows? They do and I bet it works! Replace your notepad with vim. Vim is the most incredible piece of software I've ever seen, bar none -- web browser, vice city, whatever.

ps. just ignore the GUI parts, it's all devolution