Dealing with CR (\n) from fopen in search.

I'm trying to compensate for the carriage returns given to a program both from a file read in, or a word entered by a user followed by a carriage return.

The search function doesn't appear to deal with a \n very well:

Calling search:

Code:

  printf("Now, what would you like to search for?\n");
            fgets(buffer, sizeof(buffer), stdin);
            sscanf(buffer, "%s", &query_word);
            search(root, query_word);

Search function:

Code:

void search(struct node* rootnode, char* word)
{
   struct node* new=NULL;       /* a new node */
   struct node* here=NULL;      /* where we are looking */
   struct node* root=NULL;
   here=rootnode;               /* start at the root */
   while (1)                    /* loop until I tell you to break */
   {  if (strcmp(word\n, here->data) == 0)
      {  /* the word is right here */
         printf("The word %s is in the tree!\n",word);
      }
      else if (strcmp(word, here->data) < 0)  /* need to look left */
      {  if (here->left == NULL)
         {  /* we've reached the end, and can add the new node here */
            break;
         }
         else  /* move left and loop */
         {
            here=here->left;
            if(strcmp(word, here->data) == 0)
            {
               printf("The word %s is in the tree!\n", word);
            }
         }
      }
      else if (strcmp(word, here->data) > 0)  /* need to look right */
      {  if (here->right == NULL)
         {  /* we've reached the end, and can add the new node here */
            break;
         }
         else  /* move right and loop */
         {
            here=here->right;
            if(strcmp(word, here->data) == 0)
            {
               printf("The word %s is in the tree!\n", word);
            }
         }
      }
      else
      {
         printf("The word %s is not in the tree!\n", word);
      }
   }
   /*return; */
}

How can I compensate for the new-line characters when searching?

The search function doesn't appear to deal with a \n very well

please think about your reader: he has both to find what you mean and what's wrong with your code. Could you be more precise when explaining your problem?

Code:

  printf("Now, what would you like to search for?\n");
            fgets(buffer, sizeof(buffer), stdin);
            strtok(buffer, "\n");
            sscanf(buffer, "%s", &query_word);
            search(root, query_word);

Fix your indentation though, bud.

Of course the other option is scanf() is more capable of handling this on its own than you would think. But I would just stick to using strtok().

Originally Posted by root4

please think about your reader: he has both to find what you mean and what's wrong with your code. Could you be more precise when explaining your problem?

I agree 100%. The good news is I read programming languages much faster than spoken languages and usually just scan through code to begin with. I spotted an area of concern (the line that I added) then looked up and found it was what he was asking about.

Which also goes to explain how come sometimes I will answer stuff that the OP never even asked--I was reading their dysfunctional code, and not their question.

You may need to work with something like the following as there is not chomp eqavalent in c:

Code:

while (('\n' != (ch = getc(word))) && (EOF != ch)) continue;
return ch;

Code:

if (strcmp(word\n, here->data) == 0)

???

Originally Posted by master5001

Code:

  printf("Now, what would you like to search for?\n");
            fgets(buffer, sizeof(buffer), stdin);
            strtok(buffer, "\n");
            sscanf(buffer, "%s", &query_word);
            search(root, query_word);

Fix your indentation though, bud.

I apologize for my misdirection. I've always held true to the mantra of man-pages, and being told never to use strtok with constant strings. If it's the closest equivalent of chomp, then I'll use it, otherwise...

To clarify, I have the file, which obviously has sentinel characters, inserted into a binary tree, with which I am searching for a word as given to me by a user (from stdin with a carriage return)

How is query_word declared? Looks like its of type char, revise it to be an array of char.

Originally Posted by itCbitC

How is query_word declared? Looks like its of type char, revise it to be an array of char.

I declare it as a character array:

Code:

   char query_word[MAX_LENGTH];
   welcome();
   FILE *file_ptr;
   char word[MAX_LENGTH];

Originally Posted by mlsrar

I declare it as a character array:

Code:

   char query_word[MAX_LENGTH];
   welcome();
   FILE *file_ptr;
   char word[MAX_LENGTH];

In that case your sscanf() should be revised as it's incorrect.

Code:

sscanf(buffer, "%s", &query_word);

It's just
sscanf(buffer, "%s", query_word);

given
char query_word[MAX_LENGTH];

It's just
sscanf(buffer, "%s", query_word);

given
char query_word[MAX_LENGTH];