Thread: Haaaaalp

Code:

#include<stdio.h>
#include"global.h"
#include<string.h>


/*print_array()*/
void print_array(int ia[][NUM_COLUMN], int row, int column);
read_array(FILE *fp, FILE *fp2, char string1[], char string2[]);
	int arraya[NUM_ROW][NUM_COLUMN];
	int arrayb[NUM_ROW][NUM_COLUMN];
	int arrayc[NUM_ROW][NUM_COLUMN];

int main(int argc, char **argv){
	char txt[]="txt";
	FILE *fp;
	FILE *fp2;

	if(argc!=3){
		printf("Usage: %s matrix_(letter).txt\n", argv[1]);
		return -1;
	}
	if((strstr(argv[1],txt)!=0) && (strstr(argv[2],txt)!=0)){
		printf("1st argument = %s \n", argv[1]);
		printf("2nd argument = %s \n", argv[2]);
		fp=fopen("matrix_a.txt", "r+");
		fp2=fopen("matrix_b.txt", "r+");
		printf("fp =%d\n", fp);
		printf("fp2 =%d\n", fp2);
		if(fp && fp2){
			read_array(fp, fp2, argv[1], argv[2]);
			fclose(argv[1]);
			fclose(argv[2]);			
		}else{
			printf("%s and %s Not Open\n", argv[1], argv[2]);
			exit(-1);
		}		
	}
	else
		printf("Unrecognized Arguments");

	return 0;
}/* main()*/

/*print_array()*/
/* ia is 2-Dimensional Array, 
	Row is # of rows, 
	Column is # of columns */
read_array(FILE *fp, FILE *fp2, char string1[], char string2[]){
		
}


void print_array(int ia[][NUM_COLUMN], int row, int column){
	int i,j;
	for(i=0;i<row;i++){
		for(j=0;j<column;j++)
			printf("%d ", ia[i][j]);
		printf("\n");
	}
}

why doesn't the file open? It is there i guarantee it. Please help me

Why are you opening matrix_a and matrix_b regardless of what gets typed in? And are they in the right directories?

That was just to check, and they are in the right directories, i have copied them everywhere..

Do they both not open?

And you can't fclose a char*, you can only fclose a FILE*.

yeah neither of them, and fixed the fclose lol whoops. maybe it's just a random occurence can you try it in your compiler w/ fake .txt files. I will give you 5 dollars!!

One thing the compiler noticed that I didn't is that your function and your prototype for read_array need a return type (presumably void) -- right now, read_array is just this thing, that might be a global variable, or something, but who knows.

Once I fixed that, it works fine.

thats all you did? just put type void? hmm....... thanks for you trouble pal but maybe its my compiler...

If your compiler can't handle fopen, you really need another compiler. Granted, I am not aware of a compiler that can't open a file. I would really really check that you have a "random_a.txt" and not, for instance, "randoma.txt" or "random_a.dat", or "random_a.mat", or "random_a.text" and that that file is in the same directory as your executable file (wherever that may be). (Or, heaven help us if you tried to create a .txt file in Visual Studio, "random_a.txt.cpp".

If the data in the matrix file is larger than NUM_ROW by NUM_COLUMN you're going to trash some memory. void print_array needs to take some arguments. This line

Code:

if((fp!=0)&&(fp!=0)){

needs a 2 in it. But what kind of crash are you getting, and how do you know?

NUM_ROW and NUM_COLUMN are 500 each. and the matrices I will be doing are 100 x 150. I haven't implemented print_array yet, it is commented out. I am not getting an error with the code you quoted. when I compile the code it stops working, the program. Vista says it stops working etc.

Oh right:

Code:

	for(i=0;i<row1;i++){
		for(j=0;j<column1;j++)		
			fscanf(fp,"%d", &array1[i][j]);	
		fscanf(fp,"\n");
	}

	for(i=0;i<row2;i++){
		for(j=0;j<column2;j++)
			fscanf(fp2,"%d", &array2[i][j]);				
		fscanf(fp2,"\n");
	}

That would help, thanks. Also, I am having trouble with passing by reference for the array. Shouldn't it work the way I have it? I have tried multiple ways and it seems that I either have missing subscripts and

different array subscripts : 'int (*)[1]' and 'int [500][500]

Code:

void func(int a[][], int b[][]);

int main(){
int ia[NUM_ROW][NUM_COL];
int ib[NUM_ROW][NUM_COL];
func(ia, ib);
}
void func(int a[][], int b[][]){
//code
}

Isn't this valid? Yet I get compile errors.

No. The second dimension in a function prototype MUST be given. Also, to pass an array by reference to a function, you use the array name by itself -- no &, no []. An array name, used by itself, decays to the right thing that you want to pass to a function (a pointer to its first element).