Thread: File Server Help

>Yes, shure but that mistakes are warnings,

They are warnings because often times, they are because of bugs in your program. In this case, they are from bugs in your program.

>fd_set is saying that was no declared, but it's a struct from the sockets library.

yes, but that's the library. You also need to include the proper header files.

>The same with the other socket functions..The errors on the recv and the send functions are just warning

Yes, but in this case, they are signs of bugs in your program.

>the code compiles perfectly in a simple compilation with gcc,

Just because it compiles, doesn't mean there aren't bugs in it.

>what about the select? compile the code in the normal way and check it

You have other, more basic, errors that are making your program not work right now.

According to the man pages, select (and fd_set etc.) are in <sys/select.h>.

You have to reconstruct the fd_sets you pass to select for every call. select removes the file descriptors from the fd_sets that don't have activity on them.

>But why does it removes the file descriptor from the fd_sets?

the point of select is to tell you which fds wouldn't block if you used some function on them. Removing the inactive fds leaves the active fds, which you can then read/write/send/recv on.

>the sentence is suppose to delete the connection in case that it's not responding, I've tested it as it was originally and it worked perfectly.

which line?

Code:

   if((nbytes = recv(i, buf, sizeof(buf), 0)) <= 0) { /* this thing is what I'm worried of*/
        if(nbytes == 0) {
          close(i);
          FD_CLR(i, &master);
          printf("Conexion perdida\n");
        }
        else {
          recievefile(&i);
        }

I don't know what you're trying to do there.

>I also wanna know what do you think about using fork for handling the requests,

do you have a specific question?

> I think that the select won't handle the incomming connection if it is doing the function of recieve file, I mean, two people sending a file at the same time is not possible as the code is right now right?

If you want multiple connections with select, you'll have to rearrage your code a little bit, yes. Something like this:

Code:

while do socket stuff
    set up fd_sets
    call select
    for each fd in fd_set
        if listener
            accept connection
        else if file receive connection
            recv chunk //only receive a chunk of the file at a time.
        endif
    endfor
endwhile

This line deletes non responding descriptors... It works, as it was originally, a chat server, worked perfectly

Code:

   if((nbytes = recv(i, buf, sizeof(buf), 0)) <= 0) { /* this thing is what I'm worried of*/
        if(nbytes == 0) {
          close(i);
          FD_CLR(i, &master);

How are you planning to recieve the chunk of the file and add it? Mmm.. maybe doing simplier funcion that just appended all the code recieved... well.. I think maybe that will be a little messed up.
About fork, I thought of forking the recievefile function on the incoming existent connection.

Ok, but if there is an error, then it tries to receive the file. Does that sound right?

>About fork, I thought of forking the recievefile function on the incoming existent connection.

That's another way of doing it. In that case, you wouldn't need select.

>Is that what you mean?

Yes. Then you would have to code the condition for when it actually received data.

>And about for, I think it would be nicer to have the fork and the select working together if the file server has lots of multiple connections.. and also multiple file uploads from the same client

Why would you want both? It's either one or the other when you're using it for multiple connections.

Well.. now the recieve function works, but for a strange reason, I don't know why I have to send everything twice from the client

...post your code

Server File
http://pastebin.com/m7568fec0
File Client
http://pastebin.com/m30cbd08a

Note that in the file client I've for each send a copy of it, cause if not it doesn't work and I've written lots of printf all over the code to see whats happening on the execution..

You're so not paying attention to what I'm telling you.

Seriously, if you're not going to pay attention to what I'm saying, I think I'll do likewise.